You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by bo...@apache.org on 2015/10/19 19:32:14 UTC

[09/10] android commit: You can't easily abstract out this variable because this can crash Cordova due to the plugin design.

You can't easily abstract out this variable because this can crash Cordova due to the plugin design.


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/4db1fecb
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/4db1fecb
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/4db1fecb

Branch: refs/heads/master
Commit: 4db1fecba887defbf7228edd7e4f2ab85d0d34bb
Parents: 013ad94
Author: Joe Bowser <bo...@apache.org>
Authored: Tue Oct 6 12:57:01 2015 -0700
Committer: Joe Bowser <bo...@apache.org>
Committed: Mon Oct 19 10:31:56 2015 -0700

----------------------------------------------------------------------
 framework/src/org/apache/cordova/CordovaPlugin.java | 14 --------------
 1 file changed, 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/4db1fecb/framework/src/org/apache/cordova/CordovaPlugin.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaPlugin.java b/framework/src/org/apache/cordova/CordovaPlugin.java
index 9f211ff..4627ebb 100644
--- a/framework/src/org/apache/cordova/CordovaPlugin.java
+++ b/framework/src/org/apache/cordova/CordovaPlugin.java
@@ -42,7 +42,6 @@ public class CordovaPlugin {
     public CordovaInterface cordova;
     protected CordovaPreferences preferences;
     private String serviceName;
-    protected String [] permissions;
 
     /**
      * Call this after constructing to initialize the plugin.
@@ -372,7 +371,6 @@ public class CordovaPlugin {
      */
 
     public void requestPermissions(int requestCode) {
-        cordova.requestPermissions(this, requestCode, permissions);
     }
 
     /*
@@ -383,18 +381,6 @@ public class CordovaPlugin {
      */
 
     public boolean hasPermisssion() {
-        if(Build.VERSION.SDK_INT < Build.VERSION_CODES.M)
-        {
-            return true;
-        }
-        for(String p : permissions)
-        {
-            if(PackageManager.PERMISSION_DENIED == cordova.getActivity().checkSelfPermission(p))
-            {
-                return false;
-            }
-        }
-
         return true;
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org