You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Jason Altekruse <al...@gmail.com> on 2014/08/16 02:32:55 UTC
Review Request 24759: Drill-982 Return null for non-existent columns
in parquet reader
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24759/
-----------------------------------------------------------
Review request for drill.
Summary (updated)
-----------------
Drill-982 Return null for non-existent columns in parquet reader
Repository: drill-git
Description (updated)
-------
Drill-982 Return null for non-existent columns in parquet reader
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 2228787
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java 2193233
Diff: https://reviews.apache.org/r/24759/diff/
Testing (updated)
-------
added new unit tests, ran full build on command line
Thanks,
Jason Altekruse
Re: Review Request 24759: Drill-982 Return null for non-existent
columns in parquet reader
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24759/#review51114
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On Aug. 16, 2014, 12:32 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24759/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 12:32 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Drill-982 Return null for non-existent columns in parquet reader
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 2228787
> exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java 2193233
>
> Diff: https://reviews.apache.org/r/24759/diff/
>
>
> Testing
> -------
>
> added new unit tests, ran full build on command line
>
>
> Thanks,
>
> Jason Altekruse
>
>
Re: Review Request 24759: Drill-982 Return null for non-existent
columns in parquet reader
Posted by Jason Altekruse <al...@gmail.com>.
> On Aug. 19, 2014, 5:54 a.m., Parth Chandra wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java, line 125
> > <https://reviews.apache.org/r/24759/diff/1/?file=661968#file661968line125>
> >
> > Is the columnsFound array guaranteed to be initialized to false? If not, then we haven't initialized the array.
Yes, they are initialized to false in JAVA
http://stackoverflow.com/a/12229524
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24759/#review50957
-----------------------------------------------------------
On Aug. 16, 2014, 12:32 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24759/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 12:32 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Drill-982 Return null for non-existent columns in parquet reader
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 2228787
> exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java 2193233
>
> Diff: https://reviews.apache.org/r/24759/diff/
>
>
> Testing
> -------
>
> added new unit tests, ran full build on command line
>
>
> Thanks,
>
> Jason Altekruse
>
>
Re: Review Request 24759: Drill-982 Return null for non-existent
columns in parquet reader
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24759/#review50957
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
<https://reviews.apache.org/r/24759/#comment88848>
Is the columnsFound array guaranteed to be initialized to false? If not, then we haven't initialized the array.
- Parth Chandra
On Aug. 16, 2014, 12:32 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24759/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 12:32 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Drill-982 Return null for non-existent columns in parquet reader
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java 2228787
> exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java 2193233
>
> Diff: https://reviews.apache.org/r/24759/diff/
>
>
> Testing
> -------
>
> added new unit tests, ran full build on command line
>
>
> Thanks,
>
> Jason Altekruse
>
>