You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/22 23:57:21 UTC
[GitHub] [bookkeeper] Ghatage opened a new pull request #2452: Issue 2170: Cleaned up error message for NoNodeException for lostBook…
Ghatage opened a new pull request #2452:
URL: https://github.com/apache/bookkeeper/pull/2452
…ieRecoveryDelay when Auditor is not initialized.
### Motivation
If Auditor has not been initialized, running `lostBookieRecoveryDelay` from bookie shell will result in a stack trace and `NoNodeException`.
### Changes
Added a catch clause which:
* Cleans up stack trace
* Explains that the Auditor is not up yet, which means the znode for `lostbookierecoverydelay` has not been created yet.
* Prints exception
Master Issue: #2170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2452: Issue 2170: Cleaned up error message for NoNodeException for lostBook…
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2452:
URL: https://github.com/apache/bookkeeper/pull/2452#issuecomment-715189804
@Ghatage is it generally better to not merge your own pull requests.
Recently I committed my own patches after waiting the approval of other committers but that was because we haven't many active committers who had time to merge.
Now that you are onboard I see that we will move at a faster pace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Ghatage merged pull request #2452: Issue 2170: Cleaned up error message for NoNodeException for lostBook…
Posted by GitBox <gi...@apache.org>.
Ghatage merged pull request #2452:
URL: https://github.com/apache/bookkeeper/pull/2452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Ghatage commented on pull request #2452: Issue 2170: Cleaned up error message for NoNodeException for lostBook…
Posted by GitBox <gi...@apache.org>.
Ghatage commented on pull request #2452:
URL: https://github.com/apache/bookkeeper/pull/2452#issuecomment-715409654
> @Ghatage is it generally better to not merge your own pull requests
Understood!
On Fri, Oct 23, 2020, 1:38 AM Enrico Olivelli <no...@github.com>
wrote:
> @Ghatage <https://github.com/Ghatage> is it generally better to not merge
> your own pull requests.
> Recently I committed my own patches after waiting the approval of other
> committers but that was because we haven't many active committers who had
> time to merge.
>
> Now that you are onboard I see that we will move at a faster pace
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/bookkeeper/pull/2452#issuecomment-715189804>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAX6QQJ6MI32ACJDQ3SDA6TSME6I5ANCNFSM4S33URMA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org