You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dheeraj12347 (via GitHub)" <gi...@apache.org> on 2026/02/01 11:13:58 UTC
[PR] feat: provide timeout for each operation [opendal]
dheeraj12347 opened a new pull request, #7176:
URL: https://github.com/apache/opendal/pull/7176
This PR implements per-operation timeout support as requested in #7168.
Changes:
Added timeout field and with_timeout method to OpRead, OpWrite, OpStat, and OpList in core.
Updated TimeoutLayer to prioritize per-operation timeouts over global defaults.
Fixes: #7168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: provide timeout for each operation [opendal]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on PR #7176:
URL: https://github.com/apache/opendal/pull/7176#issuecomment-3830896962
<!-- Answer -->
**Related Documentation**
No published documentation to review for changes on this repository.
[Write your first living document](https://app.dosu.dev/documents?utm_campaign=pr-doc-check-nudge)
<!-- Dosu Comment Footer -->
<sup>How did I do? Any feedback?</sup> [](https://go.dosu.dev/discord-bot)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: provide timeout for each operation [opendal]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on code in PR #7176:
URL: https://github.com/apache/opendal/pull/7176#discussion_r2757322584
##########
core/core/src/raw/ops.rs:
##########
@@ -133,6 +134,8 @@ pub struct OpList {
///
/// Default to `false`
deleted: bool,
+ /// The timeout for this operation.
+ timeout: Option<Duration>,
Review Comment:
> Thank you, but `Layer`'s behavior should never be injected into ops level.
Thank you for the feedback, @Xuanwo. I understand now that the ops level should remain agnostic of Layer behaviors.
To support per-operation timeouts without injecting them into raw/ops.rs, would you recommend using Operator::call with a custom context, or is there a preferred pattern in OpenDAL for passing per-request configurations to Layers? I'll revert the changes to ops.rs and refactor accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: provide timeout for each operation [opendal]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on PR #7176:
URL: https://github.com/apache/opendal/pull/7176#issuecomment-3840404894
> Hi, @dheeraj12347, please review your own PR before requesting a maintainer's review. This PR has now been marked as a low-quality contribution. If no further improvement is provided, I will close it directly.
>
> Reasons: This PR does not address the problem, but instead removes many existing comments. If you are unsure how to proceed, please return to the discussion before starting a PR.
Hi @Xuanwo, I sincerely apologize for the oversight. I see now that my last refactor accidentally removed existing comments and didn't solve the core issue as intended. I am stepping back to re-evaluate the architecture and will restore the deleted documentation immediately. I'll move the technical discussion back to the issue #7168 before making further pushes to ensure I'm aligned with OpenDAL's design principles. Thank you for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: provide timeout for each operation [opendal]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 closed pull request #7176: feat: provide timeout for each operation
URL: https://github.com/apache/opendal/pull/7176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: provide timeout for each operation [opendal]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on code in PR #7176:
URL: https://github.com/apache/opendal/pull/7176#discussion_r2757497710
##########
core/core/src/raw/ops.rs:
##########
@@ -133,6 +134,8 @@ pub struct OpList {
///
/// Default to `false`
deleted: bool,
+ /// The timeout for this operation.
+ timeout: Option<Duration>,
Review Comment:
> Thank you, but `Layer`'s behavior should never be injected into ops level.
I have pushed the refactored TimeoutLayer. It now handles timeouts entirely within the layer, and I've reverted all changes to the core ops.rs. The code is now architecturally clean and passes local checks. Looking forward to your guidance on the best way to re-introduce per-operation overrides!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: provide timeout for each operation [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7176:
URL: https://github.com/apache/opendal/pull/7176#issuecomment-3840341440
Hi, @dheeraj12347, please review your own PR before requesting a maintainer's review. This PR has now been marked as a low-quality contribution. If no further improvement is provided, I will close it directly.
Reasons: This PR does not address the problem, but instead removes many existing comments. If you are unsure how to proceed, please return to the discussion before starting a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: provide timeout for each operation [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #7176:
URL: https://github.com/apache/opendal/pull/7176#discussion_r2754663694
##########
core/core/src/raw/ops.rs:
##########
@@ -133,6 +134,8 @@ pub struct OpList {
///
/// Default to `false`
deleted: bool,
+ /// The timeout for this operation.
+ timeout: Option<Duration>,
Review Comment:
Thank you, but `Layer`'s behavior should never be injected into ops level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org