You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/04 07:17:23 UTC

[GitHub] graceguo-supercat commented on issue #5741: [Dashboard] Keeping refresh frequency value in Dashboard

graceguo-supercat commented on issue #5741: [Dashboard] Keeping refresh frequency value in Dashboard
URL: https://github.com/apache/incubator-superset/pull/5741#issuecomment-418265849
 
 
   Thanks for adding this feature! Very nice work! 🎊  Please see my comment for a performance suggestion. 
   
   And it will be super helpful if you can add a unit test for this new feature. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org