[GitHub] [hive] akshat0395 commented on a diff in pull request #4181: HIVE-27203: Add compaction Qtest for Insert-only, Partitioned, Clustered, and combination ACID Tables

["akshat0395 (via GitHub)" <gi...@apache.org>]

akshat0395 commented on code in PR #4181:
URL: https://github.com/apache/hive/pull/4181#discussion_r1155606740


##########
ql/src/test/queries/clientpositive/compaction_query_based_insert_only_partitioned_clustered.q:
##########


Review Comment:
   Thanks for the comment @rkirtir, These test individually and the reason for having Major and minor in separate tests is to test these compaction in isolation for different scenarios.
   This patterns has been followed in other compaction related qtests as well.
   Here are some ref that follows the same pattern:
   
   1. ql/src/test/queries/clientpositive/compaction_query_based.q
   2. ql/src/test/queries/clientpositive/compaction_query_based_clustered.q
   3. ql/src/test/queries/clientpositive/compaction_query_based_clustered_minor.q
   4. ql/src/test/queries/clientpositive/compaction_query_based_insert_only.q
   5.  ql/src/test/queries/clientpositive/compaction_query_based_insert_only_minor.q
   6. ql/src/test/queries/clientpositive/compaction_query_based_minor.q



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org