You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "yjhjstz (via GitHub)" <gi...@apache.org> on 2025/03/10 14:58:02 UTC
[PR] Fix FIPS mode checks and initialize segfile_count [cloudberry]
yjhjstz opened a new pull request, #986:
URL: https://github.com/apache/cloudberry/pull/986
Fixes when OPENSSL_FIPS defined.
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix FIPS mode checks and initialize segfile_count [cloudberry]
Posted by "avamingli (via GitHub)" <gi...@apache.org>.
avamingli commented on code in PR #986:
URL: https://github.com/apache/cloudberry/pull/986#discussion_r1992524442
##########
src/backend/access/aocs/aocsam_handler.c:
##########
@@ -1683,7 +1683,7 @@ aoco_index_build_range_scan(Relation heapRelation,
ExprContext *econtext;
Snapshot snapshot;
AOCSFileSegInfo **seginfo = NULL;
- int32 segfile_count;
+ int32 segfile_count = 0;
Review Comment:
Init it to 0 seems a way to fix warning, but the segfile_count is not assigned any more, the later use in func:
```c
FreeAllAOCSSegFileInfo(seginfo, segfile_count);
```
is always 0.
as comments in https://github.com/apache/cloudberry/issues/989
https://github.com/apache/cloudberry/issues/989#issuecomment-2716695457
We lost the logic:
```c
/*
* When Parallel index build,there is no additional operation to update the number of tuples
* that supports this logic. Uniform processing is used here.
*/
if (progress)
{
seginfo = GetAllFileSegInfo(heapRelation, snapshot, &segfile_count, NULL);
for (int seginfo_no = 0; seginfo_no < segfile_count; seginfo_no++)
{
total_blockcount += seginfo[seginfo_no]->varblockcount;
}
pgstat_progress_update_param(PROGRESS_SCAN_BLOCKS_TOTAL, total_blockcount);
}
```
Is it right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix FIPS mode checks and initialize segfile_count [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz merged PR #986:
URL: https://github.com/apache/cloudberry/pull/986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix FIPS mode checks and initialize segfile_count [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #986:
URL: https://github.com/apache/cloudberry/pull/986#discussion_r1992527719
##########
src/backend/access/aocs/aocsam_handler.c:
##########
@@ -1683,7 +1683,7 @@ aoco_index_build_range_scan(Relation heapRelation,
ExprContext *econtext;
Snapshot snapshot;
AOCSFileSegInfo **seginfo = NULL;
- int32 segfile_count;
+ int32 segfile_count = 0;
Review Comment:
we can merge this quick fix, then fix https://github.com/apache/cloudberry/issues/989 in right way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org