You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2025/03/24 15:55:57 UTC
[I] Ant Design 5: Upgrade Upload component [superset]
geido opened a new issue, #32824:
URL: https://github.com/apache/superset/issues/32824
Please refer to SIP-139 https://github.com/apache/superset/issues/29268.
The `Upload` component should be upgraded to Ant Design version 5. As all other re-usable components of the codebase the Upload component should have its own wrapper in `src/components/Upload`.
Similar work has been completed [here](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed).
**IMPORTANT:**
- The `src/components/Upload` must be upgraded to Ant Design 5 and a wrapper created inside `src/components/Upload`.
- The `src/components/Upload` wrapper should contain a RTL test file and Storybook.
- All direct imports of Upload should be refactored to use `src/components/Upload` instead.
When upgrading the component to Ant Design 5, please ensure to include:
- Do not add unnecessary custom styles. We want to go as vanilla Ant Design as possible.
- Proper RTL test coverage.
- A Storybook file.
- Include all relevant component options in the Storybook.
When opening a PR:
- Name your PR refactor({Component}): Upgrade {component} to Ant Design 5
- Add screenshots of BEFORE/AFTER in your PR.
- Update the [project tracker](https://github.com/apache/superset/discussions/29293) when your PR is merged.
- Make sure you or a committer has labeled your PR with [frontend:refactor:antd5](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Ant Design 5: Upgrade Upload component [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido closed issue #32824: Ant Design 5: Upgrade Upload component
URL: https://github.com/apache/superset/issues/32824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Ant Design 5: Upgrade Upload component [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #32824:
URL: https://github.com/apache/superset/issues/32824#issuecomment-2751687016
@EnxDev is already working on this issue and will be fixed with https://github.com/apache/superset/pull/32705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Ant Design 5: Upgrade Upload component [superset]
Posted by "abhishek818 (via GitHub)" <gi...@apache.org>.
abhishek818 commented on issue #32824:
URL: https://github.com/apache/superset/issues/32824#issuecomment-2748673406
@geido can i take this up ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Ant Design 5: Upgrade Upload component [superset]
Posted by "syedbarimanjan (via GitHub)" <gi...@apache.org>.
syedbarimanjan commented on issue #32824:
URL: https://github.com/apache/superset/issues/32824#issuecomment-2749740329
@geido I would like to work on this, sent you my implementation in slack dm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Ant Design 5: Upgrade Upload component [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #32824:
URL: https://github.com/apache/superset/issues/32824#issuecomment-2748623603
---
### 🎉 **Preset Bounty Available: $500 USD** 🎉
To claim this bounty, please carefully follow the steps below.
---
#### 📋 **Steps to Participate**
1. **Review Guidelines:**
Read through the [Preset Bounty Program Contribution Guide](https://preset.notion.site/preset-bounty-program-apache-superset) for complete details on bounty requirements.
2. **Show Your Interest:**
Complete the [Preset Bounty Program Survey](https://docs.google.com/forms/d/e/1FAIpQLSeDsR1iWvPxFydUIXs2agsUg3kMDaAooeD4P9P1L5sI0Yu5QQ/viewform?usp=sharing) and comment this issue to express your interest.
3. **Join the Slack Channel:**
After completing the survey, you’ll receive an invitation to the dedicated [Apache Superset Slack](https://join.slack.com/t/apache-superset/shared_invite/zt-2be0drwz8-bxPfkdz28ozzk1Iox29ufg) channel.
4. **Get Assigned:**
To officially start, ensure a **Bounty Program Manager** has assigned you to this issue.
5. **Submit Your Solution:**
When ready, submit your solution with the `Fixes #{issue_number}` notation in your Pull Request description.
6. **Claim Your Bounty:**
Sign up at [GitPay.me](https://gitpay.me/) and submit your solution via: [https://gitpay.me/#/task/1086](https://gitpay.me/#/task/1086)
---
#### 💡 **Additional Notes**
- Only developers assigned by a **Bounty Program Manager** should start working on this issue to win the bounty.
- Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.
Good luck, and happy coding! 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org