[GitHub] [trafficserver] maskit commented on a change in pull request #7808: Fix origin session related crashes

[GitBox <gi...@apache.org>]

maskit commented on a change in pull request #7808:
URL: https://github.com/apache/trafficserver/pull/7808#discussion_r630661453



##########
File path: iocore/net/SSLUtils.cc
##########
@@ -2034,7 +2034,12 @@ SSLConnect(SSL *ssl)
 
       Debug("ssl.origin_session_cache", "origin session cache lookup key = %s", lookup_key.c_str());
 
-      sess = origin_sess_cache->get_session(lookup_key);
+      TLSSessionResumptionSupport *srs = TLSSessionResumptionSupport::getInstance(ssl);

Review comment:
       Adding these lines here is actually a bit of sad thing, because `SSLConnect` was originally independent from NetVC. You could use it for any SSL connections. `SSLReadBuffer` too, before supporting early data. I think that's the reason those functions are in SSLUtils.
   
   Now those two functions depend on NetVC, and there is no longer a reason to have those in SSLUtils as non-member functions. Although I don't think we should do this on this PR, we should probably make the two functions (and SSLWriteBuffer) member functions of SSLNetVC and move them to P_SSLNetVConnection.h. Then we don't need to call `getInstance` to call `getOriginSession`.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org