You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/11/13 02:12:37 UTC
Review Request 27947: Setting the max thread limit on AsyncEventBus.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-926
https://issues.apache.org/jira/browse/AURORA-926
Repository: aurora
Description
-------
Setting the max thread limit on AsyncEventBus.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
Diff: https://reviews.apache.org/r/27947/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Nov. 13, 2014, 4:27 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java, line 98
> > <https://reviews.apache.org/r/27947/diff/1/?file=760831#file760831line98>
> >
> > I don't think we want enqueuing a pubsubevent for processing to block, ever (otherwise we open ourselves to the possibility of deadlocks here). Consider using a LinkedBlockingQueue instead here. As this queue is still bounded at MAX_INT we might further consider adding a https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/RejectedExecutionHandler.html that logs an appropriate message and shuts down the scheduler to make debugging easier.
This is actually how the Executors.newCachedThreadPool() configures the async bus executor now. The only difference in this diff is capping the maxPoolSize to something more sane than Integer.MAX_VALUE.
Looking at the ThreadPoolExecutor and the SynchronousQueue implementation it's not going to block when threads are busy/exhausted. The SynchronousQueue.offer() is going to timeout immediately (return false) and the ThreadPoolExecutor.execute() will proceed straight to reject(), where the default AbortPolicy would result in a RejectedExecutionException thrown in a thread calling EventBus.post(). So, the debugging story should be addressed well here. What is not addressed though is the fact that we are going to fail on start any time producers outrun consumers - pretty much guaranteed in a large cluster.
I am going to switch to the newFixedThreadPool() with a few threads as Bill suggested. It already uses LinkedBlockingQueue and it's unlikely that we ever exceed Integer.MAX_VALUE on queueing side with multiple consuming threads.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61203
-----------------------------------------------------------
On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:12 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61203
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java
<https://reviews.apache.org/r/27947/#comment102725>
I don't think we want enqueuing a pubsubevent for processing to block, ever (otherwise we open ourselves to the possibility of deadlocks here). Consider using a LinkedBlockingQueue instead here. As this queue is still bounded at MAX_INT we might further consider adding a https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/RejectedExecutionHandler.html that logs an appropriate message and shuts down the scheduler to make debugging easier.
- Kevin Sweeney
On Nov. 12, 2014, 5:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 5:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 13, 2014, 1:35 a.m., Aurora ReviewBot wrote:
> > %s
> >
> > However, it appears that it might lack test coverage.
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Oy, i really should not work on review bot when i'm tired.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61168
-----------------------------------------------------------
On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:12 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61168
-----------------------------------------------------------
%s
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:12 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 13, 2014, 2:07 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java, line 93
> > <https://reviews.apache.org/r/27947/diff/1/?file=760831#file760831line93>
> >
> > Given that we're moving from an effective "same thread executor" to async, i think we can get by with fewer knobs for now. How about:
> >
> > Executors.newFixedThreadPool(
> > PUBSUB_WORKER_THREADS.get(),
> > ...
>
> Maxim Khutornenko wrote:
> That was my first choice but ulimately decided in favor of the current approach to avoid a fixed memory tax of 1Mb X num_threads. With the current setting of 500 that would result in a constant "waste" of 500MB of JVM heap even when there is no event pressure.
Good point. I'd actually suggest reducing the thread count dramatically, though, maybe 4 by default. We've been doing well with 1 for a long time, and throughput isn't driving the need for the async bus.
I also wonder if we should not use `SynchronousQueue`. Since we're bounding the number of threads, busy threads means we'll force the work producer to wait for an available consumer. I think in that case we'd rather queue the work item and let the submitter proceed. What's your take?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61178
-----------------------------------------------------------
On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:12 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Nov. 13, 2014, 2:07 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java, line 93
> > <https://reviews.apache.org/r/27947/diff/1/?file=760831#file760831line93>
> >
> > Given that we're moving from an effective "same thread executor" to async, i think we can get by with fewer knobs for now. How about:
> >
> > Executors.newFixedThreadPool(
> > PUBSUB_WORKER_THREADS.get(),
> > ...
>
> Maxim Khutornenko wrote:
> That was my first choice but ulimately decided in favor of the current approach to avoid a fixed memory tax of 1Mb X num_threads. With the current setting of 500 that would result in a constant "waste" of 500MB of JVM heap even when there is no event pressure.
>
> Bill Farner wrote:
> Good point. I'd actually suggest reducing the thread count dramatically, though, maybe 4 by default. We've been doing well with 1 for a long time, and throughput isn't driving the need for the async bus.
>
> I also wonder if we should not use `SynchronousQueue`. Since we're bounding the number of threads, busy threads means we'll force the work producer to wait for an available consumer. I think in that case we'd rather queue the work item and let the submitter proceed. What's your take?
Agree, see my reply to Kevin for reasoning behind this.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61178
-----------------------------------------------------------
On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:12 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Nov. 13, 2014, 2:07 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java, line 93
> > <https://reviews.apache.org/r/27947/diff/1/?file=760831#file760831line93>
> >
> > Given that we're moving from an effective "same thread executor" to async, i think we can get by with fewer knobs for now. How about:
> >
> > Executors.newFixedThreadPool(
> > PUBSUB_WORKER_THREADS.get(),
> > ...
That was my first choice but ulimately decided in favor of the current approach to avoid a fixed memory tax of 1Mb X num_threads. With the current setting of 500 that would result in a constant "waste" of 500MB of JVM heap even when there is no event pressure.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61178
-----------------------------------------------------------
On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:12 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61178
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java
<https://reviews.apache.org/r/27947/#comment102698>
Given that we're moving from an effective "same thread executor" to async, i think we can get by with fewer knobs for now. How about:
Executors.newFixedThreadPool(
PUBSUB_WORKER_THREADS.get(),
...
- Bill Farner
On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:12 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61310
-----------------------------------------------------------
Ship it!
Master (de5a9b7) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 13, 2014, 7:33 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 7:33 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
> src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java af3f0e3dc4f845c464dd6d9fc9f6b28ca8ad8c36
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61306
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 13, 2014, 11:33 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 11:33 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
> src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java af3f0e3dc4f845c464dd6d9fc9f6b28ca8ad8c36
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/
-----------------------------------------------------------
(Updated Nov. 13, 2014, 7:33 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Refactored to expose a queue size stat.
Moved DeadEvent handler into a private class to avoid "Uncallable method org.apache.aurora.scheduler.events.PubsubEventModule$2.logDeadEvent(DeadEvent) defined in anonymous class" findBugs error.
Bugs: AURORA-926
https://issues.apache.org/jira/browse/AURORA-926
Repository: aurora
Description
-------
Setting the max thread limit on AsyncEventBus.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java af3f0e3dc4f845c464dd6d9fc9f6b28ca8ad8c36
Diff: https://reviews.apache.org/r/27947/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61278
-----------------------------------------------------------
%s
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 13, 2014, 5:41 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 5:41 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61279
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java
<https://reviews.apache.org/r/27947/#comment102819>
Can you inject your own `LinkedBlockingQueue` and export its size in a metric?
- Bill Farner
On Nov. 13, 2014, 5:41 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 5:41 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-926
> https://issues.apache.org/jira/browse/AURORA-926
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Setting the max thread limit on AsyncEventBus.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
>
> Diff: https://reviews.apache.org/r/27947/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27947: Setting the max thread limit on
AsyncEventBus.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/
-----------------------------------------------------------
(Updated Nov. 13, 2014, 5:41 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-926
https://issues.apache.org/jira/browse/AURORA-926
Repository: aurora
Description
-------
Setting the max thread limit on AsyncEventBus.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2
Diff: https://reviews.apache.org/r/27947/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko