[GitHub] [accumulo] jzgithub1 commented on issue #1435: Master OOME during GCUpgrade9to10TestIT (test fails)

[GitBox <gi...@apache.org>]

jzgithub1 commented on issue #1435: Master OOME during GCUpgrade9to10TestIT (test fails)
URL: https://github.com/apache/accumulo/issues/1435#issuecomment-584838036
 
 
   @ctubbsii ,  this is the only error I see when running this test  but it is not related to OOME.  The call to deleteLock in killMacGc  always fails. 
   
   `2020-02-11 14:59:33,790 [functional.ConfigurableMacBase] ERROR: Unable to delete ZooLock for mini accumulo-gc
   java.lang.IllegalStateException: No lock is held at /accumulo/8d868a12-346d-4e31-98ba-fed5f5e04a16/gc/lock
   	at org.apache.accumulo.fate.zookeeper.ZooLock.deleteLock(ZooLock.java:499)
   	at org.apache.accumulo.test.upgrade.GCUpgrade9to10TestIT.killMacGc(GCUpgrade9to10TestIT.java:94)`
   Maybe we can just remove that try catch block with ZooLock.deleteLock in it and add a check to see if the GC process is actually running before we kill it to keep the intent and purpose of the killMacGC function in tact.  
   
   Here is the code change I suggest:
   ```java
   private void killMacGc() throws ProcessNotFoundException, InterruptedException {
       // kill gc started by MAC
       assertNotNull(getCluster().getProcesses().get(ServerType.GARBAGE_COLLECTOR));
       getCluster().killProcess(ServerType.GARBAGE_COLLECTOR,
           getCluster().getProcesses().get(ServerType.GARBAGE_COLLECTOR).iterator().next());
       assertNull(getCluster().getProcesses().get(ServerType.GARBAGE_COLLECTOR));
     }
   ```
   
   
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services