[GitHub] [incubator-superset] john-bodley commented on a change in pull request #7889: [test] fix postgres test failure caused by empty slice.name

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #7889: [test] fix postgres test failure caused by empty slice.name
URL: https://github.com/apache/incubator-superset/pull/7889#discussion_r304698307
 
 

 ##########
 File path: tests/import_export_tests.py
 ##########
 @@ -145,8 +145,12 @@ def assert_dash_equals(self, expected_dash, actual_dash, check_position=True):
         self.assertEquals(expected_dash.slug, actual_dash.slug)
         self.assertEquals(expected_dash.dashboard_title, actual_dash.dashboard_title)
         self.assertEquals(len(expected_dash.slices), len(actual_dash.slices))
-        expected_slices = sorted(expected_dash.slices, key=lambda s: s.slice_name or "")
-        actual_slices = sorted(actual_dash.slices, key=lambda s: s.slice_name or "")
+        expected_slices = sorted(
 
 Review comment:
   Why not just use the `slice.id`, i.e., `expected_slices = sorted( expected_dash.slices, key=lambda s: s.id)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org