You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "Horacio Hoyos Rodriguez (JIRA)" <ji...@apache.org> on 2018/07/05 09:11:00 UTC

[jira] [Created] (TINKERPOP-1997) Tests allow Integer - Double equivalences

Horacio Hoyos Rodriguez created TINKERPOP-1997:
--------------------------------------------------

             Summary: Tests allow Integer - Double equivalences 
                 Key: TINKERPOP-1997
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1997
             Project: TinkerPop
          Issue Type: Improvement
          Components: io
    Affects Versions: 3.3.3
            Reporter: Horacio Hoyos Rodriguez


In ArangoDB doubles with 0 decimals are serialised and later deserialised as Intengers, e.g. a weight of 1.0 will be stored as 1 and deserialised as Integer(1).

In the TestSuite (I think mostly the IO tests), there is an assertion for validating that the weight of the edges are Doubles. In this case, the test fails because Integer != Double.

Shouldn't it be enough to compare values? In Java the Integer will be promoted to Double. 

The same issue happens when the assert compares representations: 

       x=1.0 != x=1

Can these be relaxed further to allow this discrepancies, but equivalent values, to be used?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)