[GitHub] [helix] rahulrane50 commented on a diff in pull request #2418: Fix CI testcase failure: TestMultiZkConnection

["rahulrane50 (via GitHub)" <gi...@apache.org>]

rahulrane50 commented on code in PR #2418:
URL: https://github.com/apache/helix/pull/2418#discussion_r1146857478


##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java:
##########
@@ -86,7 +86,7 @@ public class TestMultiZkHelixJavaApis extends TestMultiZkConnectionConfig {
 
   @BeforeClass
   public void beforeClass() throws Exception {
-    super.beforeClass();
+    super.beforeApiClass();

Review Comment:
   If my understanding is correct then you are bypassing _zkClient object creation from TestMultiZkConnectionConfig class. If that's true then we should add few null checks in TestMultiZkConnectionConfig.setupCluster or other methods. This is just to make sure that any user of TestMultiZkConnectionConfig now expects to initialize _zkClient object. 



##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java:
##########
@@ -86,7 +86,7 @@ public class TestMultiZkHelixJavaApis extends TestMultiZkConnectionConfig {
 
   @BeforeClass
   public void beforeClass() throws Exception {
-    super.beforeClass();
+    super.beforeApiClass();

Review Comment:
   Another point, i think we are not even using _zkClient anywhere in the test here right? if not we can completely remove it from this test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org