You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/05 14:02:22 UTC
[GitHub] [incubator-nuttx-apps] iceaway opened a new pull request #231: Hdc1008
iceaway opened a new pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231
## Summary
Example application showing how to use the hdc1008 driver (see pull request 975: https://github.com/apache/incubator-nuttx/pull/975). Let me know if the copyright stuff needs to change.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#discussion_r420226140
##########
File path: examples/hdc1008_demo/Make.defs
##########
@@ -0,0 +1,39 @@
+############################################################################
+# apps/examples/hdc1008_demo/Make.defs
+# Adds selected applications to apps/ build
+#
+# Copyright (C) 2020 Pelle Windestam. All rights reserved.
+# Author: Pelle Windestam <pe...@windestam.se>
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in
+# the documentation and/or other materials provided with the
+# distribution.
+# 3. Neither the name NuttX nor the names of its contributors may be
+# used to endorse or promote products derived from this software
+# without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+#
+############################################################################
Review comment:
This must have an Apache 2.0 header. Use the one from nuttx/sched/sched/sched_getcpu.c. Note that there is no author or copyright in that header.
##########
File path: examples/hdc1008_demo/Makefile
##########
@@ -0,0 +1,47 @@
+############################################################################
+# apps/examples/hdc1008_demo/Makefile
+#
+# Copyright (C) 2020 Pelle Windestam. All rights reserved.
+# Author: Pelle Windestam <pe...@windestam.se>
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in
+# the documentation and/or other materials provided with the
+# distribution.
+# 3. Neither the name NuttX nor the names of its contributors may be
+# used to endorse or promote products derived from this software
+# without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+#
+############################################################################
Review comment:
This must have an Apache 2.0 header. Use the one from nuttx/sched/sched/sched_getcpu.c. Note that there is no author or copyright in that header.
##########
File path: examples/hdc1008_demo/hdc1008_main.c
##########
@@ -0,0 +1,184 @@
+/****************************************************************************
+ * examples/hdc1008_demo/hdc1008_main.c
+ *
+ * Copyright (C) 2020 Pelle Windestam. All rights reserved.
+ * Author: Pelle Windestam <pe...@windestam.se>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/
Review comment:
This must have an Apache 2.0 header. Use the one from nuttx/sched/sched/sched_getcpu.c. Note that there is no author or copyright in that header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] iceaway commented on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
iceaway commented on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624276371
I think I screwed something up now....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624409713
If something get wrong, create a new branch, cherry-pick and rebase the change again. Don't worry, nothing can be lost after you commit. you can even find the lost change by "git reflog".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624128593
Should we remove the 2nd patch and merge the 3rd into the 1st? also the copyright need change to Apache for all new files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624128593
Should we remove the 2nd patch and merge the 3rd into the 1st? also the copyright need change to Apache for the new file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624264157
> Headers are now updated to the apache 2.0 license. Not sure what you meant about merging the patches @xiaoxiang781216 . Is that something I can do on my branch or is it done by whoever merges this to master?
This PR has four patch, but it make sense to merge into one like this:
git rebase --interactive HEAD~4
select squach
git push -f origin hdc1008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624295357
Try rebasing against the master then doing a force push to your branch. That might do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] iceaway commented on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
iceaway commented on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624430651
Go ahead and close this one, I opened up a new pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] iceaway edited a comment on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
iceaway edited a comment on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624276371
I think I screwed something up now.... Any way to revert this mess?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624409713
If something get wrong, create a new branch, cherry-pick and rebase the change again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] iceaway commented on pull request #231: Hdc1008
Posted by GitBox <gi...@apache.org>.
iceaway commented on pull request #231:
URL: https://github.com/apache/incubator-nuttx-apps/pull/231#issuecomment-624257295
Headers are now updated to the apache 2.0 license. Not sure what you meant about merging the patches @xiaoxiang781216 . Is that something I can do on my branch or is it done by whoever merges this to master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org