You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/26 10:08:18 UTC
[GitHub] [doris] dataroaring opened a new pull request, #12981: [improvement](memory) set TCMALLOC_HEAP_LIMIT_MB to control memory co…
dataroaring opened a new pull request, #12981:
URL: https://github.com/apache/doris/pull/12981
…nsumption of tcmalloc
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12981: [improvement](memory) set TCMALLOC_HEAP_LIMIT_MB to control memory co…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12981:
URL: https://github.com/apache/doris/pull/12981#issuecomment-1259388558
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3134322503") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In bin/start_be.sh line 210:
mem_limit_str=$(grep ^mem_limit ${DORIS_HOME}/conf/be.conf)
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mem_limit_str=$(grep ^mem_limit "${DORIS_HOME}"/conf/be.conf)
In bin/start_be.sh line 218:
case $unit in
^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
case ${unit} in
In bin/start_be.sh line 231:
if [[ "$mem_limit_mb" -gt "$total_mem_mb" ]]; then
^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
if [[ "${mem_limit_mb}" -gt "${total_mem_mb}" ]]; then
In bin/start_be.sh line 232:
echo "mem_limit is larger than whole memory of the server. $mem_limit_mb > $total_mem_mb."
^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
echo "mem_limit is larger than whole memory of the server. ${mem_limit_mb} > ${total_mem_mb}."
In bin/start_be.sh line 235:
export TCMALLOC_HEAP_LIMIT_MB=$mem_limit_mb
^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
export TCMALLOC_HEAP_LIMIT_MB=${mem_limit_mb}
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz merged pull request #12981: [improvement](memory) set TCMALLOC_HEAP_LIMIT_MB to control memory co…
Posted by GitBox <gi...@apache.org>.
xinyiZzz merged PR #12981:
URL: https://github.com/apache/doris/pull/12981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12981: [improvement](memory) set TCMALLOC_HEAP_LIMIT_MB to control memory co…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12981:
URL: https://github.com/apache/doris/pull/12981#issuecomment-1258385565
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12981: [improvement](memory) set TCMALLOC_HEAP_LIMIT_MB to control memory co…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12981:
URL: https://github.com/apache/doris/pull/12981#issuecomment-1259775333
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3135573969") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In bin/start_be.sh line 210:
mem_limit_str=$(grep ^mem_limit ${DORIS_HOME}/conf/be.conf)
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mem_limit_str=$(grep ^mem_limit "${DORIS_HOME}"/conf/be.conf)
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12981: [improvement](memory) set TCMALLOC_HEAP_LIMIT_MB to control memory co…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12981:
URL: https://github.com/apache/doris/pull/12981#issuecomment-1258385518
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12981: [improvement](memory) set TCMALLOC_HEAP_LIMIT_MB to control memory co…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12981:
URL: https://github.com/apache/doris/pull/12981#issuecomment-1260469831
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org