You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "Kevin Risden (Jira)" <ji...@apache.org> on 2023/04/02 14:13:00 UTC

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

    [ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707665#comment-17707665 ] 

Kevin Risden commented on SOLR-16427:
-------------------------------------

So as of April 1 - https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle - there are 30 todo left in the error-prone.gradle file.
* 26 of them are need to evaluate if the rule is useful or add a comment if not
* 3 look like valuable rules but to enable need to fix the issues
* 1 is potentially converting to forbiddenapis instead of error-prone for that one rule

> Evaluate and fix errorprone rules
> ---------------------------------
>
>                 Key: SOLR-16427
>                 URL: https://issues.apache.org/jira/browse/SOLR-16427
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>          Time Spent: 9.5h
>  Remaining Estimate: 0h
>
> Errorprone has many rules and there are a bunch that are disabled in Solr. Some make sense to leave disabled. Others are just disabled because they weren't evaluated.
> See https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle
> This was previously done for some rules in SOLR-15908 and SOLR-15613. This relates to SOLR-16364



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org