[GitHub] dbalek commented on a change in pull request #406: Adding basic support for vars

[GitBox <gi...@apache.org>]

dbalek commented on a change in pull request #406: Adding basic support for vars
URL: https://github.com/apache/incubator-netbeans/pull/406#discussion_r167596844
 
 

 ##########
 File path: java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java
 ##########
 @@ -3731,6 +3746,11 @@ private void addTypes(Env env, EnumSet<ElementKind> kinds, DeclaredType baseType
             addLocalAndImportedTypes(env, kinds, baseType);
             hasAdditionalClasses = true;
         }
+        if (SOURCE_VERSION_RELEASE_10 != null &&
 
 Review comment:
   Consider moving this to the `addKeywordsForBlock` method. Check for `env.getPath().getLeaf().getKind() == Tree.Kind.BLOCK` would not be necessary there. Also, check for `Utilities.startsWith(VAR_KEYWORD, prefix)` should be added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists