[GitHub] [spark] attilapiros commented on a change in pull request #24314: [SPARK-27404][CORE][SQL][STREAMING][YARN] Fix build warnings for 3.0: postfixOps edition

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #24314: [SPARK-27404][CORE][SQL][STREAMING][YARN] Fix build warnings for 3.0: postfixOps edition
URL: https://github.com/apache/spark/pull/24314#discussion_r273034819
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/rpc/RpcEnvSuite.scala
 ##########
 @@ -658,7 +657,7 @@ abstract class RpcEnvSuite extends SparkFunSuite with BeforeAndAfterAll {
       })
       val rpcEndpointRef = remoteEnv.setupEndpointRef(localEnv.address, "send-authentication")
       rpcEndpointRef.send("hello")
-      eventually(timeout(5 seconds), interval(10 millis)) {
+      eventually(timeout(5.seconds), interval(10.millis)) {
 
 Review comment:
   `10.millis` => `10.milliseconds`
   
   There are a few other places where this pattern is repeated:
   ```
   (pr/24314) $ git diff 017919b636  | grep "^\+.*millis[^e]"
   +    eventually(timeout(1.minute), interval(10.millis)) {
   +        rpcEndpointRef.askSync[String]("hello", new RpcTimeout(1.millis, shortProp))
   +      eventually(timeout(5.seconds), interval(10.millis)) {
   +    eventually(timeout(1.minute), interval(200.millis)) {
   +      Await.ready(f, 50.millis)
   +      eventually(timeout(20.seconds), interval(batchDuration.milliseconds.millis)) {
   +      eventually(timeout(10.seconds), interval(10.millis)) {
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org