You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by co...@apache.org on 2014/10/05 00:35:57 UTC

svn commit: r1629454 - /webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/crypto/CryptoBase.java

Author: coheigea
Date: Sat Oct  4 22:35:56 2014
New Revision: 1629454

URL: http://svn.apache.org/r1629454
Log:
Fix potential NPE

Modified:
    webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/crypto/CryptoBase.java

Modified: webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/crypto/CryptoBase.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/crypto/CryptoBase.java?rev=1629454&r1=1629453&r2=1629454&view=diff
==============================================================================
--- webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/crypto/CryptoBase.java (original)
+++ webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/crypto/CryptoBase.java Sat Oct  4 22:35:56 2014
@@ -320,7 +320,7 @@ public abstract class CryptoBase impleme
     matches(
         final X509Certificate cert, final Collection<Pattern> subjectDNPatterns
     ) {
-        if (subjectDNPatterns.isEmpty()) {
+        if (subjectDNPatterns == null || subjectDNPatterns.isEmpty()) {
             LOG.warn("No Subject DN Certificate Constraints were defined. This could be a security issue");
         }
         if (!subjectDNPatterns.isEmpty()) {