You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/07/20 08:21:16 UTC
Review Request 67997: Added a test
`ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810
Repository: mesos
Description
-------
Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Diffs
-----
src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 97b35a4dfb4c5942858bad5fbc743fd205dd4c3c
Diff: https://reviews.apache.org/r/67997/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67997: Added a test
`ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/#review213279
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 25, 2019, 7:03 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67997/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2019, 7:03 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp cbe677880d6a7dc44697fa5a425b8164dbb4f6e2
>
>
> Diff: https://reviews.apache.org/r/67997/diff/4/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67997: Added a test
`ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/
-----------------------------------------------------------
(Updated Feb. 26, 2019, 11:03 a.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Made the test verify the ownership of the volume path.
Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810
Repository: mesos
Description
-------
Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Diffs (updated)
-----
src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp cbe677880d6a7dc44697fa5a425b8164dbb4f6e2
Diff: https://reviews.apache.org/r/67997/diff/4/
Changes: https://reviews.apache.org/r/67997/diff/3-4/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67997: Added a test
`ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/#review213135
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 6, 2019, 4:58 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67997/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2019, 4:58 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp cbe677880d6a7dc44697fa5a425b8164dbb4f6e2
>
>
> Diff: https://reviews.apache.org/r/67997/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67997: Added a test
`ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/
-----------------------------------------------------------
(Updated Jan. 7, 2019, 8:58 a.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Minor changes.
Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810
Repository: mesos
Description
-------
Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Diffs (updated)
-----
src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp cbe677880d6a7dc44697fa5a425b8164dbb4f6e2
Diff: https://reviews.apache.org/r/67997/diff/3/
Changes: https://reviews.apache.org/r/67997/diff/2-3/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67997: Added a test
`ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/#review211238
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On Dec. 11, 2018, 6:45 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67997/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2018, 6:45 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp cbe677880d6a7dc44697fa5a425b8164dbb4f6e2
>
>
> Diff: https://reviews.apache.org/r/67997/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67997: Added a test
`ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/
-----------------------------------------------------------
(Updated Dec. 11, 2018, 2:45 p.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810
Repository: mesos
Description
-------
Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Diffs (updated)
-----
src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp cbe677880d6a7dc44697fa5a425b8164dbb4f6e2
Diff: https://reviews.apache.org/r/67997/diff/2/
Changes: https://reviews.apache.org/r/67997/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67997: Added a test
`ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/#review206270
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66811.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 66811`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1963/mesos-review-67997
Relevant logs:
- [apply-review-66811-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1963/mesos-review-67997/logs/apply-review-66811-stdout.log):
```
error: patch failed: 3rdparty/stout/CMakeLists.txt:30
error: 3rdparty/stout/CMakeLists.txt: patch does not apply
```
- Mesos Reviewbot Windows
On July 20, 2018, 10:21 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67997/
> -----------------------------------------------------------
>
> (Updated July 20, 2018, 10:21 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 97b35a4dfb4c5942858bad5fbc743fd205dd4c3c
>
>
> Diff: https://reviews.apache.org/r/67997/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>