You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2015/03/31 07:06:07 UTC
[GitHub] spark pull request: [SPARK-5124][Core] Move StopCoordinator to the...
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/5283
[SPARK-5124][Core] Move StopCoordinator to the receive method since it does not require a reply
Hotfix for #4588
cc @rxin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5283
----
commit cf3e5a7766131de8d272664dbcdd065f821d4428
Author: zsxwing <zs...@gmail.com>
Date: 2015-03-31T05:03:50Z
Move StopCoordinator to the receive method since it does not require a reply
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5124][Core] Move StopCoordinator to the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5283#issuecomment-87954800
[Test build #29446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29446/consoleFull) for PR 5283 at commit [`cf3e5a7`](https://github.com/apache/spark/commit/cf3e5a7766131de8d272664dbcdd065f821d4428).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5124][Core] Move StopCoordinator to the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5283#issuecomment-87940965
[Test build #29446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29446/consoleFull) for PR 5283 at commit [`cf3e5a7`](https://github.com/apache/spark/commit/cf3e5a7766131de8d272664dbcdd065f821d4428).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5124][Core] Move StopCoordinator to the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5124][Core] Move StopCoordinator to the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5283#issuecomment-87954806
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29446/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5124][Core] Move StopCoordinator to the...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5283#issuecomment-87941255
Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org