[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4425: Setting snapshot state to error on timeout

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4425:
URL: https://github.com/apache/cloudstack/pull/4425#discussion_r519859781



##########
File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -553,6 +553,25 @@ private void postCreateRecurringSnapshotForPolicy(long userId, long volumeId, lo
         }
     }
 
+    public void markFailedSnapshot(long snapshotId) {
+        Account caller = CallContext.current().getCallingAccount();
+
+        // Verify parameters
+        SnapshotVO snapshotCheck = _snapshotDao.findById(snapshotId);
+
+        if (snapshotCheck == null) {
+            throw new InvalidParameterValueException("unable to find a snapshot with id " + snapshotId);
+        }
+
+        _accountMgr.checkAccess(caller, null, true, snapshotCheck);
+
+        snapshotCheck.setState(Snapshot.State.Error);
+        _snapshotDao.update(snapshotId, snapshotCheck);
+        // Setting removed to prevent record from being deleted by garbage collection.
+        _snapshotDao.remove(snapshotId);

Review comment:
       should this be in a transaction to be sure?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org