[GitHub] storm pull request #1528: STORM-1934 Fix race condition between sync-supervi...

[HeartSaVioR <gi...@git.apache.org>]

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1528#discussion_r69245914
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
    @@ -425,6 +433,13 @@
              ". State: " state
              ", Heartbeat: " (pr-str heartbeat))
             (shutdown-worker supervisor id)))
    +
    +    (doseq [storm-id all-downloaded-storm-ids]
    --- End diff --
    
    @harshach 
    I agree that it would be nice to keep topology code until topology gets killed, but since this is same to what it was, I guess we can handle this as new issue for improvement.
    Btw, `assignment-snapshot` seems hiding no topology info (I mean killed) vs no assignment. We should let assignment-snapshot distinguish both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---