You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/07 15:57:18 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4036: Split object_store into separate workspace
tustvold opened a new pull request, #4036:
URL: https://github.com/apache/arrow-rs/pull/4036
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Relates to #4030
Closes #3414
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
`object_store` follows a separate release cycle and is distributed independently, having it in the same workspace creates friction and requires workarounds that then cause their own issues. Simpler to just keep it separate.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Splits object_store into its own workspace
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4036: Split object_store into separate workspace
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4036:
URL: https://github.com/apache/arrow-rs/pull/4036#discussion_r1160797438
##########
dev/release/verify-release-candidate.sh:
##########
@@ -105,26 +105,15 @@ test_source_distribution() {
# raises on any formatting errors
rustup component add rustfmt --toolchain stable
- (cd arrow && cargo fmt --check)
- (cd arrow-flight && cargo fmt --check)
- (cd parquet && cargo fmt --check)
- (cd parquet_derive && cargo fmt --check)
+ cargo fmt --all -- --check
# Clone testing repositories if not cloned already
git clone https://github.com/apache/arrow-testing.git arrow-testing-data
git clone https://github.com/apache/parquet-testing.git parquet-testing-data
export ARROW_TEST_DATA=$PWD/arrow-testing-data/data
export PARQUET_TEST_DATA=$PWD/parquet-testing-data/data
- (cd arrow && cargo build && cargo test)
- (cd arrow-flight && cargo build && cargo test)
- # To avoid https://github.com/apache/arrow-rs/issues/3410,
- # remove path reference from parquet:
- # object_store = { version = "0.5", path = "../object_store", default-features = false, optional = true }
- # object_store = { version = "0.5", default-features = false, optional = true }
- sed -i -e 's/\(^object_store.*\)\(path = ".*", \)/\1/g' parquet/Cargo.toml
- (cd parquet && cargo build && cargo test)
- (cd parquet_derive && cargo build && cargo test)
+ cargo test --all
Review Comment:
As an added bonus this is a more thorough verification, as it will run the tests for the child crates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4036: Split object_store into separate workspace
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4036:
URL: https://github.com/apache/arrow-rs/pull/4036#discussion_r1160797704
##########
dev/release/create-tarball.sh:
##########
@@ -117,14 +117,11 @@ echo "---------------------------------------------------------"
# create <tarball> containing the files in git at $release_hash
# the files in the tarball are prefixed with {tag} (e.g. 4.0.1)
-# use --delete to filter out:
-# 1. `object_store` files
-# 2. Workspace `Cargo.toml` file (which refers to object_store)
+# use --delete to filter out `object_store` files
mkdir -p ${distdir}
(cd "${SOURCE_TOP_DIR}" && \
git archive ${release_hash} --prefix ${release}/ \
| $tar --delete ${release}/'object_store' \
- | $tar --delete ${release}/'Cargo.toml' \
Review Comment:
Following #3936 this causes issues, as it removes the workspace from which the properties are derived
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4036: Split object_store into separate workspace
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4036:
URL: https://github.com/apache/arrow-rs/pull/4036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4036: Split object_store into separate workspace
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4036:
URL: https://github.com/apache/arrow-rs/pull/4036#discussion_r1160798817
##########
dev/release/verify-release-candidate.sh:
##########
@@ -105,26 +105,15 @@ test_source_distribution() {
# raises on any formatting errors
rustup component add rustfmt --toolchain stable
- (cd arrow && cargo fmt --check)
- (cd arrow-flight && cargo fmt --check)
- (cd parquet && cargo fmt --check)
- (cd parquet_derive && cargo fmt --check)
+ cargo fmt --all -- --check
# Clone testing repositories if not cloned already
git clone https://github.com/apache/arrow-testing.git arrow-testing-data
git clone https://github.com/apache/parquet-testing.git parquet-testing-data
export ARROW_TEST_DATA=$PWD/arrow-testing-data/data
export PARQUET_TEST_DATA=$PWD/parquet-testing-data/data
- (cd arrow && cargo build && cargo test)
- (cd arrow-flight && cargo build && cargo test)
- # To avoid https://github.com/apache/arrow-rs/issues/3410,
- # remove path reference from parquet:
- # object_store = { version = "0.5", path = "../object_store", default-features = false, optional = true }
- # object_store = { version = "0.5", default-features = false, optional = true }
- sed -i -e 's/\(^object_store.*\)\(path = ".*", \)/\1/g' parquet/Cargo.toml
- (cd parquet && cargo build && cargo test)
- (cd parquet_derive && cargo build && cargo test)
+ cargo test --all
Review Comment:
I do wonder if we should be passing more features to this, but this is strictly better than it was before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4036: Split object_store into separate workspace
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4036:
URL: https://github.com/apache/arrow-rs/pull/4036#discussion_r1160797838
##########
parquet/Cargo.toml:
##########
@@ -43,7 +43,8 @@ arrow-data = { workspace = true, optional = true }
arrow-schema = { workspace = true, optional = true }
arrow-select = { workspace = true, optional = true }
arrow-ipc = { workspace = true, optional = true }
-object_store = { version = "0.5", path = "../object_store", default-features = false, optional = true }
+# Intentionally not a path dependency as object_store is released separately
+object_store = { version = "0.5", default-features = false, optional = true }
Review Comment:
This fixes #3414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org