You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/08/08 15:40:37 UTC
[GitHub] [nifi] mattyb149 commented on a change in pull request #3631:
NIFI-6513 PutHive3Streaming.AUTO_CREATE_PARTITIONS is not used
mattyb149 commented on a change in pull request #3631: NIFI-6513 PutHive3Streaming.AUTO_CREATE_PARTITIONS is not used
URL: https://github.com/apache/nifi/pull/3631#discussion_r312105628
##########
File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java
##########
@@ -151,28 +151,19 @@
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
- static final PropertyDescriptor PARTITION_VALUES = new PropertyDescriptor.Builder()
+ static final PropertyDescriptor STATIC_PARTITION_VALUES = new PropertyDescriptor.Builder()
.name("hive3-stream-part-vals")
- .displayName("Partition Values")
+ .displayName("Static Partition Values")
.description("Specifies a comma-separated list of the values for the partition columns of the target table. If the incoming records all have the same values "
+ "for the partition columns, those values can be entered here, resulting in a performance gain. If specified, this property will often contain "
+ "Expression Language, for example if PartitionRecord is upstream and two partitions 'name' and 'age' are used, then this property can be set to "
- + "${name},${age}.")
+ + "${name},${age}.\n"
+ + "Having this property filled implies Hive Static Partitioning.")
.required(false)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
- static final PropertyDescriptor AUTOCREATE_PARTITIONS = new PropertyDescriptor.Builder()
Review comment:
Removing a required field will cause all existing processors to be marked invalid upon upgrade. Not saying we should keep it, but wanted to leave that note here for posterity :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services