You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2009/08/04 16:11:14 UTC
[jira] Created: (QPID-2028) Broker test do not cleanup
ApplicationRegistry that they create
Broker test do not cleanup ApplicationRegistry that they create
---------------------------------------------------------------
Key: QPID-2028
URL: https://issues.apache.org/jira/browse/QPID-2028
Project: Qpid
Issue Type: Bug
Components: Java Tests
Reporter: Martin Ritchie
Fix For: 0.6
Summmary:
The non-unit tests in the broker package that cause an ApplicationRegistry to be created do not correctly remove this registry at the end of the test. This is what causes the ApplicationRegistry errors at the end of the ant run.
Sharing ARs between tests will increase the likelyhood of cross contamination of tests leading to spurious failures.
The tests should ensure that the correctly close any AR they create.
This is more relevant now as the new broker logging uses a ThreadLocal to maintain the current logger and only through a correct clean up of all tests can it be successfully tested in isolation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2028) Broker test do not cleanup
ApplicationRegistry that they create
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie resolved QPID-2028.
----------------------------------
Resolution: Fixed
Current trunk 'ant test' run suggest ARs are correctly being cleaned up.
> Broker test do not cleanup ApplicationRegistry that they create
> ---------------------------------------------------------------
>
> Key: QPID-2028
> URL: https://issues.apache.org/jira/browse/QPID-2028
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: 0.6
>
>
> Summmary:
> The non-unit tests in the broker package that cause an ApplicationRegistry to be created do not correctly remove this registry at the end of the test. This is what causes the ApplicationRegistry errors at the end of the ant run.
> Sharing ARs between tests will increase the likelyhood of cross contamination of tests leading to spurious failures.
> The tests should ensure that the correctly close any AR they create.
> This is more relevant now as the new broker logging uses a ThreadLocal to maintain the current logger and only through a correct clean up of all tests can it be successfully tested in isolation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2028) Broker test do not cleanup
ApplicationRegistry that they create
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-2028:
------------------------------------
Assignee: Martin Ritchie
> Broker test do not cleanup ApplicationRegistry that they create
> ---------------------------------------------------------------
>
> Key: QPID-2028
> URL: https://issues.apache.org/jira/browse/QPID-2028
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: 0.6
>
>
> Summmary:
> The non-unit tests in the broker package that cause an ApplicationRegistry to be created do not correctly remove this registry at the end of the test. This is what causes the ApplicationRegistry errors at the end of the ant run.
> Sharing ARs between tests will increase the likelyhood of cross contamination of tests leading to spurious failures.
> The tests should ensure that the correctly close any AR they create.
> This is more relevant now as the new broker logging uses a ThreadLocal to maintain the current logger and only through a correct clean up of all tests can it be successfully tested in isolation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2028) Broker test do not cleanup
ApplicationRegistry that they create
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790752#action_12790752 ]
Martin Ritchie commented on QPID-2028:
--------------------------------------
Current trunk 'ant test' run doesn't highlight that ARs are not being cleaned up. Resoloving this issue.
> Broker test do not cleanup ApplicationRegistry that they create
> ---------------------------------------------------------------
>
> Key: QPID-2028
> URL: https://issues.apache.org/jira/browse/QPID-2028
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: 0.6
>
>
> Summmary:
> The non-unit tests in the broker package that cause an ApplicationRegistry to be created do not correctly remove this registry at the end of the test. This is what causes the ApplicationRegistry errors at the end of the ant run.
> Sharing ARs between tests will increase the likelyhood of cross contamination of tests leading to spurious failures.
> The tests should ensure that the correctly close any AR they create.
> This is more relevant now as the new broker logging uses a ThreadLocal to maintain the current logger and only through a correct clean up of all tests can it be successfully tested in isolation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2028) Broker test do not cleanup
ApplicationRegistry that they create
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760267#action_12760267 ]
Martin Ritchie commented on QPID-2028:
--------------------------------------
This may not be limited to the broker tests. A straight 'ant test' run now has 3-4 inVM brokers that exit at the end of the test run.
> Broker test do not cleanup ApplicationRegistry that they create
> ---------------------------------------------------------------
>
> Key: QPID-2028
> URL: https://issues.apache.org/jira/browse/QPID-2028
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: 0.6
>
>
> Summmary:
> The non-unit tests in the broker package that cause an ApplicationRegistry to be created do not correctly remove this registry at the end of the test. This is what causes the ApplicationRegistry errors at the end of the ant run.
> Sharing ARs between tests will increase the likelyhood of cross contamination of tests leading to spurious failures.
> The tests should ensure that the correctly close any AR they create.
> This is more relevant now as the new broker logging uses a ThreadLocal to maintain the current logger and only through a correct clean up of all tests can it be successfully tested in isolation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org