[GitHub] JaroslavTulach commented on a change in pull request #1096: Verify 'GraalVM:js' engine is created.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #1096: Verify 'GraalVM:js' engine is created.
URL: https://github.com/apache/incubator-netbeans/pull/1096#discussion_r250234513
 
 

 ##########
 File path: webcommon/libs.graaljs/test/unit/src/org/netbeans/libs/graaljs/GraalJSTest.java
 ##########
 @@ -21,21 +21,29 @@
 import javax.script.ScriptEngine;
 import javax.script.ScriptEngineFactory;
 import javax.script.ScriptEngineManager;
+import junit.framework.Test;
 import org.graalvm.polyglot.Context;
-import static org.junit.Assert.assertEquals;
-import org.junit.Test;
 import org.netbeans.api.scripting.Scripting;
+import org.netbeans.junit.NbModuleSuite;
+import org.netbeans.junit.NbTestCase;
 
-public class GraalJSTest {
-    @Test
-    public void evaluateGraalJS() {
+public final class GraalJSTest extends NbTestCase {
+    public GraalJSTest(String name) {
+        super(name);
+    }
+
+    public static Test suite() {
+        return NbModuleSuite.createConfiguration(GraalJSTest.class).suite();
 
 Review comment:
   We have to test in real runtime container (with `NbModuleSuite`) as otherwise (with flat classpath) we don't see all the classloader problems of Graal SDK, Truffle API and languages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists