You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Martijn van Groningen (JIRA)" <ji...@apache.org> on 2017/01/25 13:20:26 UTC
[jira] [Comment Edited] (LUCENE-6959) Remove
ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837714#comment-15837714 ]
Martijn van Groningen edited comment on LUCENE-6959 at 1/25/17 1:19 PM:
------------------------------------------------------------------------
I've modified Adrien's patch and ported the ES query mentioned in my previous comment to Lucene join module.
bq. I'd like to understand a bit better how exactly we can re-implement this functionality once we remove the collector. That ES query class seems to be created for each parent doc that made the top N hits, right?
Yes, that is what it is doing.
was (Author: martijn.v.groningen):
I've modified Adrien's patch and ported the ES query mentioned in my previous comment to Lucene join module.
> I'd like to understand a bit better how exactly we can re-implement this functionality once we remove the collector. That ES query class seems to be created for each parent doc that made the top N hits, right?
Yes, that is what it is doing.
> Remove ToParentBlockJoinCollector
> ---------------------------------
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed in Scorer, which are not always available (eg. disjunctions expose fake scorers) hence the need for a dedicated IndexSearcher (ToParentBlockJoinIndexSearcher). Given that this is the only collector in this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org