[GitHub] [solr] dsmiley commented on a change in pull request #526: SOLR-15916: Remove dist from distribution.

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #526:
URL: https://github.com/apache/solr/pull/526#discussion_r785023141



##########
File path: solr/solr-ref-guide/src/jdbc-dbvisualizer.adoc
##########
@@ -22,8 +22,8 @@ For DbVisualizer, you will need to create a new driver for Solr using the DbVisu
 This will add several SolrJ client .jars to the DbVisualizer classpath.
 The files required are:
 
-* all .jars found in `$SOLR_HOME/dist/solrj-lib`
-* the SolrJ .jar found at `$SOLR_HOME/dist/solr-solrj-<version>.jar`
+* all .jars found in `$SOLR_HOME/server/solr-webapp/webapp/WEB-INF/lib/\*` and `$SOLR_HOME/server/lib/ext/*`

Review comment:
       Seeing above line 22 "all JARs" on these paths... well... like Jan commented above, it isn't actually all of them.  Nonetheless I could see that for a JdbcVisualizer how-to, that practically speaking it may be easiest to add them all? (did you try this?).  It'd be nice if we could have gradle dump a text file of the dependency list so the user knows which are needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org