You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Keith Laban (JIRA)" <ji...@apache.org> on 2016/03/01 19:56:18 UTC
[jira] [Updated] (SOLR-5616) Make grouping code use response
builder needDocList
[ https://issues.apache.org/jira/browse/SOLR-5616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Laban updated SOLR-5616:
------------------------------
Attachment: SOLR-5616.patch
Attached new, addressing [~erickerickson] comments from way back when. test suite passes when running locally
> Make grouping code use response builder needDocList
> ---------------------------------------------------
>
> Key: SOLR-5616
> URL: https://issues.apache.org/jira/browse/SOLR-5616
> Project: Solr
> Issue Type: Bug
> Reporter: Steven Bower
> Assignee: Erick Erickson
> Attachments: SOLR-5616.patch, SOLR-5616.patch, SOLR-5616.patch
>
>
> Right now the grouping code does this to check if it needs to generate a docList for grouped results:
> {code}
> if (rb.doHighlights || rb.isDebug() || params.getBool(MoreLikeThisParams.MLT, false) ){
> ...
> }
> {code}
> this is ugly because any new component that needs a doclist, from grouped results, will need to modify QueryComponent to add a check to this if. Ideally this should just use the rb.isNeedDocList() flag...
> Coincidentally this boolean is really never used at for non-grouped results it always gets generated..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org