You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/19 23:53:50 UTC

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15249


Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................

[clock] KUDU-3048 add builtin-NTP-specific metrics

Added metrics specific to the built-in NTP client:
  * info : difference between tracked true time and local wallclock
  * debug: most recently computed true time
  * debug: histogram on the maximum error of the computed true time

I re-visited the level of recently introduced metrics in HybridClock.

Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
---
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
4 files changed, 124 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/15249/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15249

to look at the new patch set (#5).

Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................

[clock] KUDU-3048 add builtin-NTP-specific metrics

Added metrics specific to the built-in NTP client:
  * info : difference between tracked true time and local wallclock
  * debug: most recently computed true time
  * debug: histogram on the maximum error of the computed true time

For testing, I manually ran kudu-master and verified the newly
introduced metrics are present and their values make sense.

I also re-visited the level of recently introduced metrics in the
HybridClock class.

Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
---
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/clock/ntp-test.cc
5 files changed, 135 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/15249/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15249 )

Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 05:04:40 +0000
Gerrit-HasComments: No

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15249

to look at the new patch set (#4).

Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................

[clock] KUDU-3048 add builtin-NTP-specific metrics

Added metrics specific to the built-in NTP client:
  * info : difference between tracked true time and local wallclock
  * debug: most recently computed true time
  * debug: histogram on the maximum error of the computed true time

For testing, I manually ran kudu-master and verified the newly
introduced metrics are present and their values make sense.

I also re-visited the level of recently introduced metrics in the
HybridClock class.

Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
---
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/clock/ntp-test.cc
5 files changed, 134 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/15249/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15249 )

Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................

[clock] KUDU-3048 add builtin-NTP-specific metrics

Added metrics specific to the built-in NTP client:
  * info : difference between tracked true time and local wallclock
  * debug: most recently computed true time
  * debug: histogram on the maximum error of the computed true time

For testing, I manually ran kudu-master and verified the newly
introduced metrics are present and their values make sense.

I also re-visited the level of recently introduced metrics in the
HybridClock class.

Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Reviewed-on: http://gerrit.cloudera.org:8080/15249
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/clock/ntp-test.cc
5 files changed, 135 insertions(+), 25 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15249

to look at the new patch set (#3).

Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................

[clock] KUDU-3048 add builtin-NTP-specific metrics

Added metrics specific to the built-in NTP client:
  * info : difference between tracked true time and local wallclock
  * debug: most recently computed true time
  * debug: histogram on the maximum error of the computed true time

For testing, I manually ran kudu-master and verified the newly
introduced metrics are present and their values make sense.

I also re-visited the level of recently introduced metrics in the
HybridClock class.

Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
---
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/clock/ntp-test.cc
5 files changed, 142 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/15249/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15249 )

Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................


Patch Set 3:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc
File src/kudu/clock/builtin_ntp.cc:

http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@117
PS2, Line 117: 9223372036854775807
maybe 2^64-1 would be more clear?


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@506
PS2, Line 506:   if (metric_entity) {
Isn't metric_entity always non-null?


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@1105
PS2, Line 1105: CLangTidy
clang-tidy


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@1107
PS2, Line 1107: sched_yeild
sched_yield


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@1109
PS2, Line 1109:   sched_yield();
Bear in mind that function metrics are called en masse in response to an access to /metrics, regardless of query parameters. Does sched_yield() add noticeable latency to such calls, especially for the periodic collection into the diagnostics log?


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@1110
PS2, Line 1110: err
rename to indicate that this is ignored?



-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 01:09:55 +0000
Gerrit-HasComments: Yes

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15249

to look at the new patch set (#2).

Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................

[clock] KUDU-3048 add builtin-NTP-specific metrics

Added metrics specific to the built-in NTP client:
  * info : difference between tracked true time and local wallclock
  * debug: most recently computed true time
  * debug: histogram on the maximum error of the computed true time

I re-visited the level of recently introduced metrics in HybridClock.

Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
---
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/clock/ntp-test.cc
5 files changed, 140 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/15249/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR] [clock] KUDU-3048 add builtin-NTP-specific metrics

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15249 )

Change subject: [clock] KUDU-3048 add builtin-NTP-specific metrics
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc
File src/kudu/clock/builtin_ntp.cc:

http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@117
PS2, Line 117: 2^63-1 when true ti
> maybe 2^64-1 would be more clear?
Done


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@506
PS2, Line 506:   RegisterMetrics(metric_entity);
> Isn't metric_entity always non-null?
Indeed: in this revision it's always non-null.


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@1105
PS2, Line 1105: s<int64_t
> clang-tidy
Done


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@1107
PS2, Line 1107: 
> sched_yield
Done


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@1109
PS2, Line 1109:   // is reported in milliseconds: don't take into account the timing of the
> Bear in mind that function metrics are called en masse in response to an ac
It's a good call.  Especially given the fact WalltimeWithError() might be waiting a bit on a shared lock.

I removed sched_yield() and added a comment.


http://gerrit.cloudera.org:8080/#/c/15249/2/src/kudu/clock/builtin_ntp.cc@1110
PS2, Line 1110: 
> rename to indicate that this is ignored?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a13d58c6e5da50ef7a98ae73de267ec4eab491
Gerrit-Change-Number: 15249
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 02:41:06 +0000
Gerrit-HasComments: Yes