svn commit: r765336 - in /tapestry/tapestry5/trunk/tapestry-core/src/main: java/org/apache/tapestry5/corelib/components/GridRows.java resources/org/apache/tapestry5/corelib/components/GridRows.tml

[hl...@apache.org]

Author: hlship
Date: Wed Apr 15 20:01:26 2009
New Revision: 765336

URL: http://svn.apache.org/viewvc?rev=765336&view=rev
Log:
TAP5-353: Description of volatile parameter for the Grid component is misleading, should be clear that application is responsible for the tracking the row

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/GridRows.java
    tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridRows.tml

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/GridRows.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/GridRows.java?rev=765336&r1=765335&r2=765336&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/GridRows.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/GridRows.java Wed Apr 15 20:01:26 2009
@@ -57,10 +57,11 @@
     private int startRow;
 
     private boolean recordStateByIndex;
+
     private boolean recordStateByEncoder;
 
     /**
-     * This action is used when a {@link org.apache.tapestry5.PrimaryKeyEncoder} is not.
+     * This action is used when a {@link org.apache.tapestry5.ValueEncoder} is not provided.
      */
     static class SetupForRowByIndex implements ComponentAction<GridRows>
     {
@@ -158,8 +159,10 @@
     private boolean lean;
 
     /**
-     * If true and the Loop is enclosed by a Form, then the normal state saving logic is turned off. Defaults to false,
-     * enabling state saving logic within Forms.
+     * If true and the component is enclosed by a Form, then the normal state saving logic is turned off. Defaults to
+     * false, enabling state saving logic within Forms. This can be set to false when form elements within the Grid are
+     * not related to the current row of the grid, or where another component (such as {@link
+     * org.apache.tapestry5.corelib.components.Hidden}) is used to maintain row state.
      */
     @Parameter(name = "volatile")
     private boolean volatileState;

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridRows.tml
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridRows.tml?rev=765336&r1=765335&r2=765336&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridRows.tml (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridRows.tml Wed Apr 15 20:01:26 2009
@@ -1,5 +1,5 @@
 <tr class="${rowClass}" xml:space="default" xmlns:t="http://tapestry.apache.org/schema/tapestry_5_0_0.xsd">
-    <t:loop source="propertyNames" value="propertyName" index="columnIndex" volatile="inherit:volatile">
+    <t:loop source="propertyNames" value="propertyName" index="columnIndex" volatile="true">
         <td class="${cellClass}" t:type="any" t:mixins="NotEmpty">
             <t:gridcell model="columnModel" object="row" overrides="overrides"/>
         </td>