You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/08/02 21:11:13 UTC
[GitHub] [pinot] xiangfu0 opened a new pull request, #11252: Upgrade joda-time lib and timezone index
xiangfu0 opened a new pull request, #11252:
URL: https://github.com/apache/pinot/pull/11252
- upgrade joda-time from 2.11.2 to 2.12.5
- remove a deprecated time zone `US/Pacific-New`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on pull request #11252: Upgrade joda-time lib and timezone index
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #11252:
URL: https://github.com/apache/pinot/pull/11252#issuecomment-1664464063
>
The issue is due to the time zone difference, I got it running on PDT, but CI runs from UTC I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on pull request #11252: Upgrade joda-time lib and timezone index
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on PR #11252:
URL: https://github.com/apache/pinot/pull/11252#issuecomment-1664229803
test failure seems legit
```
ResourceBasedQueriesTest.testQueryTestCasesWithOutput:264->lambda$testQueryTestCasesWithOutput$3:264->QueryRunnerTestBase.compareRowEquals:338 Not match at (0,0)! Expected: [450] Actual: [0] expected [0] but found [-1]
Error: ResourceBasedQueriesTest.testQueryTestCasesWithOutput:264->lambda$testQueryTestCasesWithOutput$3:264->QueryRunnerTestBase.compareRowEquals:338 Not match at (0,0)! Expected: [0] Actual: [-86400000] expected [0] but found [-1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11252: Upgrade joda-time lib and timezone index
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11252:
URL: https://github.com/apache/pinot/pull/11252#issuecomment-1663040158
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11252?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11252](https://app.codecov.io/gh/apache/pinot/pull/11252?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (027b8bc) into [master](https://app.codecov.io/gh/apache/pinot/commit/d01d4f9a3d0b1b7e17dbbcf11bf6e6add0e9c36d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d01d4f9) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11252 +/- ##
=======================================
Coverage 0.11% 0.11%
=======================================
Files 2229 2229
Lines 119957 119957
Branches 18173 18173
=======================================
Hits 137 137
Misses 119800 119800
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `0.00% <ø> (ø)` | |
| integration1temurin20 | `0.00% <ø> (ø)` | |
| integration2temurin11 | `0.00% <ø> (ø)` | |
| integration2temurin17 | `0.00% <ø> (ø)` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `0.11% <ø> (ø)` | |
| unittests2temurin17 | `0.11% <ø> (ø)` | |
| unittests2temurin20 | `0.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #11252: Upgrade joda-time lib and timezone index
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #11252:
URL: https://github.com/apache/pinot/pull/11252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org