[GitHub] [trafficcontrol] zrhoffman commented on pull request #6669: TO API Tests in CiaB: Do not test API v1

[GitBox <gi...@apache.org>]

zrhoffman commented on pull request #6669:
URL: https://github.com/apache/trafficcontrol/pull/6669#issuecomment-1071449703


   > I ran the tests locally and got a v4 failure.
   for readability:
   ```go
   parameters_test.go:489: Invalid ID shouldn't have any response {[{url_sig_msods1.config 10000 0001-01-01 00:00:00 +0000 UTC location [91 93] false /remap/config/location/parameter}] {[]}} Error <nil>
       parameters_test.go:340: cannot DELETE Parameters by Invalid ID: <nil> - {[{param was deleted. success}]}
       parameters_test.go:343: Expected 404 status code, got 200
   ```
   
   Earlier today, I got a different failure from v4 in CiaB:
   
   ```go
   servers_test.go:1342: got expected error when updating Server Type of a server assigned to DSes - type change update alerts: {Alerts:[{Text:server type can not be updated when it is currently assigned to Delivery Services Level:error}]}, err: error requesting Traffic Ops: path '[https://trafficops.infra.ciab.test:443/api/4.0/servers/3438](https://trafficops.infra.ciab.test/api/4.0/servers/3438)' gave HTTP error 409 Conflict - error-level alerts: server type can not be updated when it is currently assigned to Delivery Services
       servers_test.go:501: Expected 200 status code, got 304
   ```
   <hr>
   
   
   > Curious why this is happening - also, why do we still have this dockerfile if they can not pass for months at a time without anyone noticing?
   
   We need to pay better attention to it
   
   > Maybe we should just get rid of it instead? The GHAs already run the API tests.
   
   Yes the GHAs run the TO API tests, but this failure is not in GHA, so we lose test coverage by removing it from CiaB.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org