[GitHub] utzig commented on issue #762: upgrade STM32 Cube for the F4, and re-org to make future upgrades eas?

[GitBox <gi...@apache.org>]

utzig commented on issue #762: upgrade STM32 Cube for the F4, and re-org to make future upgrades eas?
URL: https://github.com/apache/mynewt-core/pull/762#issuecomment-360454624
 
 
   > I've configured the build of STM32Cube to ignore the "default" files i2c and spi, so instead we build the ones in our HAL. This should be changed so our HAL has a non-conflicting implementation and is still evil, but will help things in the short term.
   
   This is not done correctly I think. This rule:
   
   ```
   pkg.ign_files:
       - "stm32f4xx_hal_i2c.c"
       - "stm32f4xx_hal_spi.c"
   ```
   
   ignores both `hw/mcu/stm/stm32f4xx/src/stm32f4xx_hal_(i2c|spi).c` and the same named files inside `ext/Drivers/STM32F4xx_HAL_Driver/Src`, so in practice my projects that have `i2c` or `spi` enabled are not building.
   
   As a temporary change I don't mind this very much (it should be fixed soon!).
   
   I tested this updated HAL on a stm32f4-discovery and everything works fine (have not tested `i2c/spi`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services