You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by brenzi <no...@github.com.INVALID> on 2021/09/13 12:03:06 UTC

[apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

This SDK is behind Intel's SDK for quite a while already and the supported rust compiler is very old.

We currently face a deadlock because https://github.com/dtolnay/proc-macro2/pull/296 breaks our build. We can't downgrade, because other dependencies request proc-macro2-1.0.29. But we can't upgrade because teaclave's rust compiler support is outdated.

Please upgrade ASAP

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by volcano <no...@github.com.INVALID>.
@brenzi SDK has been upgraded.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-938567118

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by brenzi <no...@github.com.INVALID>.
when can we expect the release of 1.1.4?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-962151062

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by Pi Delport <no...@github.com.INVALID>.
Awesome!

Does that resolve this issue?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-979839601

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by haerdib <no...@github.com.INVALID>.
Some update: Upgrade to rust-toolchain nightly-2021-11-13 is not possible, because of the following error:
```bash
error[E0522]: definition of an unknown language item: `begin_panic_fmt`
   --> /.cargo/git/checkouts/incubator-teaclave-sgx-sdk-f208006cdf70a903/19355dc/sgx_tstd/src/panicking.rs:406:1
    |
406 | #[lang = "begin_panic_fmt"]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition of unknown language item `begin_panic_fmt`

```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-970252525

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by volcano <no...@github.com.INVALID>.
@PiDelport 
`v1.1.4-testing` can support `intel sgx sdk 2.15.1` and `dcap 1.12.1`


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-979652553

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by volcano <no...@github.com.INVALID>.
@PiDelport This issue has been resolved.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-989810983

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by Sylvain Bellemare <no...@github.com.INVALID>.
Thanks for the detailed answer @volcano0dr!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-951537208

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by volcano <no...@github.com.INVALID>.
@PiDelport sorry for the late upgrade. 
I 'v upgraded the SDK to support rust-nightly-2021-09-13, and the updated vesion is `1.1.4.` The latest SDK has been pushed to `v1.1.4-testing` branch.
Any respondes will be greatly welcome.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-935801990

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Thanks for the report. I'll link a related PR here: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/349

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-918552275

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by Mingshen Sun <no...@github.com.INVALID>.
@brenzi, as discussed with @volcano0dr, he's working on a new release recently. You'll see the changes in this month.

In the meantime, I suggest to pin to a specific version (through vendoring) to avoid such problem.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-919570408

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by volcano <no...@github.com.INVALID>.
@sbellem 

- The `master` branch fully supports Intel sgx sdk 2.14. The rust-toolchain is `nightly-2020-10-25`.(The `master` branch can also be compiled with `rust-nightly-2020-03-30)`
- The `v1.1.4-testing` branch fully supports Intel sgx sdk 2.15. The rust-toolchain is `nightly-2021-09-13`.
- After testing, the `v1.1.4-testing` branch will be merged into the `master` branch.
- If you plan to use Intel sgx sdk 2.14 now, it is best to use the `master` branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-951519092

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by volcano <no...@github.com.INVALID>.
@haerdib I will upgrade rust-toolchain again recently to support rust `edition 2021`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-970336177

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by Sylvain Bellemare <no...@github.com.INVALID>.
A few questions & observations:

* Is the `master` branch considered to be fully supportive of the C++ SDK 2.14?
* Is there a reason why the `rust-toolchain` on `master` `is nightly-2020-10-25` whereas on the branch https://github.com/apache/incubator-teaclave-sgx-sdk/tree/v1.1.4-testing it's `nightly-2021-09-13`.
* The branch https://github.com/apache/incubator-teaclave-sgx-sdk/tree/v1.1.4-testing is now at 2.15 for the C++ SDK. Are you planning to skip 2.14 in terms of releases, meaning that 1.1.4 will be for 2.15? 
* Would it be possible to clarify which branch is best to use for the C++ SDK 2.14?

Thank you.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-951476953

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by Pi Delport <no...@github.com.INVALID>.
Upstream release: [Intel SGX SDK 2.15.1 Release Notes](https://download.01.org/intel-sgx/sgx-linux/2.15.1/docs/Intel_SGX_SDK_Release_Notes_Linux_2.15.1_Open_Source.pdf) (12 Nov 2021)

Changes in version 2.15.1:

> * Upgraded to OpenSSL 1.1.1l.

Does `v1.1.4-testing` need any update for this?

Is anything else still blocking it from being merged?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-979349550

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by haerdib <no...@github.com.INVALID>.
We were able to test it and it seems to work perfectly, thanks alot. `proc-macro` was updated to `v1.0.32` and rust version to `nightly-2021-10-01`, which successfully built. (https://github.com/integritee-network/worker/pull/486)
Currently, ugly patching to a teaclave fork is neccesary for the mesalock libraries to work, since cargo does not allow patches to the same github repo. Other than that, nothing to complain about. Thanks alot for your effort!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-958917231

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by volcano <no...@github.com.INVALID>.
@haerdib I have upgraded rust-toolchain to `nightly-2021-11-01.`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-989808142

Re: [apache/incubator-teaclave-sgx-sdk] upgrade SDK and rust compiler urgently needed (#360)

Posted by Pi Delport <no...@github.com.INVALID>.
@mssun, @volcano0dr: Do you have any status update about the new release? Can SDK users or contributors do anything to help?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/360#issuecomment-933328339