[jira] [Commented] (SPARK-17704) ChiSqSelector performance improvement.

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-17704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528825#comment-15528825 ] 

Apache Spark commented on SPARK-17704:
--------------------------------------

User 'yanboliang' has created a pull request for this issue:
https://github.com/apache/spark/pull/15277

> ChiSqSelector performance improvement.
> --------------------------------------
>
>                 Key: SPARK-17704
>                 URL: https://issues.apache.org/jira/browse/SPARK-17704
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML, MLlib
>            Reporter: Yanbo Liang
>
> Several performance improvement for {{ChiSqSelector}}:
> 1, Keep {{selectedFeatures}} ordered ascendent.
> {{ChiSqSelectorModel.transform}} need {{selectedFeatures}} ordered to make prediction. We should sort it when training model rather than making prediction, since users usually train model once and use the model to do prediction multiple times. 
> 2, When training {{fpr}} type {{ChiSqSelectorModel}}, it's not necessary to sort the ChiSq test result by statistic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org