[GitHub] [druid] gianm commented on a diff in pull request #13075: Move JDK11 ITs to cron stage

[GitBox <gi...@apache.org>]

gianm commented on code in PR #13075:
URL: https://github.com/apache/druid/pull/13075#discussion_r971373245


##########
.travis.yml:
##########
@@ -65,7 +66,7 @@ stages:
   - name: Tests - phase 2
     if: type != cron
   - name: cron
-    if: type = cron
+    if: type = cron OR (type != pull_request AND branch != master)

Review Comment:
   https://docs.travis-ci.com/user/conditions-v1 says the possible `type` are `push`, `pull_request`, `api`, `cron`. So these tests will now additionally run for nonmaster branches if the event type is `push` or `api`. I guess `api` is for manually-triggered tests on branches. What's `push` for?



##########
distribution/asf-release-process-guide.md:
##########
@@ -113,9 +113,11 @@ For docs, please make sure to add any relevant redirects in `website/redirects.j
 
 ### Release branch hygiene
 
-The only additions to the release branch after branching should be bug fixes, which should be back-ported from the master branch, via a second PR, not with a direct PR to the release branch. Bug fix release branches may be initially populated via cherry-picking, but it is recommended to leave at least 1 commit to do as a backport PR in order to run through CI. (Note that CI is sometimes flaky for older branches).
+The only additions to the release branch after branching should be bug fixes, which should be back-ported from the master branch, via a second PR or a cherry-pick, not with a direct PR to the release branch.  
 
-Once all issues and PRs that are still tagged with the release milestone have been merged, closed, or removed from the milestone, the next step is to put together a release candidate.
+Release manager must also ensure that CI is passing successfully on the release branch. Since CI on branch can contain additional tests such as ITs for different JVM flavours. (Note that CI is sometimes flaky for older branches).

Review Comment:
   Could you please include some instruction about how to ensure that CI passes successfully on the branch? Like, a link or a description of what to click where?



##########
.travis.yml:
##########
@@ -53,7 +53,8 @@ install: ./check_test_suite.py && travis_terminate 0  || echo 'Running Maven ins
 # 2. Tests - phase 2
 # 3. cron
 #
-# The cron type only runs jobs that are marked with stage cron.
+# The cron type only runs jobs that are marked with stage cron. The ron stage also runs alongside

Review Comment:
   "cron stage" (spelling)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org