[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #520: [Refactor] Change abstract class Checker to interface

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #520:
URL: https://github.com/apache/incubator-uniffle/pull/520#discussion_r1090276313


##########
server/src/main/java/org/apache/uniffle/server/Checker.java:
##########
@@ -17,13 +17,6 @@
 
 package org.apache.uniffle.server;
 
-public abstract class Checker {
-
-  protected ShuffleServerConf conf;
-
-  Checker(ShuffleServerConf conf) {
-    this.conf = conf;
-  }
-
-  abstract boolean checkIsHealthy();
+public interface Checker {

Review Comment:
   > Rename to `StorageChecker` ? And this part could be moved into Storage's checker package? WDYT
   
   `HealthCheck` is also in `org.apache.uniffle.server`, should we move that also?
   
   > And why we need to change this class to interface? It looks fine for me.
   
   The protected field `conf` is never read. But seems the failed test is relying on constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org