You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhuhaifengleon <gi...@git.apache.org> on 2016/11/19 07:38:30 UTC
[GitHub] flink pull request #2833: [FLINK-5103] [Metrics] TaskManager process virtual...
GitHub user zhuhaifengleon opened a pull request:
https://github.com/apache/flink/pull/2833
[FLINK-5103] [Metrics] TaskManager process virtual memory and physical memory used size gauge
This PR add TaskManger process virtual memory and physical memory used size gauge metrics.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuhaifengleon/flink FLINK-5103
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2833.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2833
----
commit f65176360593ab72a6fee27f4ae54a143e386a67
Author: zhuhaifengleon <zh...@gmail.com>
Date: 2016-11-11T01:29:53Z
[metrics] expose process VmRSS/VmSize metrics
commit 5f1bf29913b809f6dad178b7f0e7e59381dfdd6a
Author: zhuhaifengleon <zh...@gmail.com>
Date: 2016-11-19T07:22:50Z
[FLINK-5103] [Metrics] TaskManager process virtual memory and physical memory used size gauge
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2833: [FLINK-5103] [Metrics] TaskManager process virtual memory...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2833
There is currently a metric group `JVM` already. This adds a metric group `Process`. What is the difference between the two? Can the new metrics be added to the `JVM` group instead? That would help to prevent fragmenting the metric groups.
I would also suggest to move the code that accesses CPU utilization into the `Hardware` class. That is where we put code that uses OS specific utilities to access for example memory and CPU.
Please also use the `OperatingSystem` class to identify operating systems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---