You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/08/28 17:12:45 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42704: [SPARK-44989][INFRA] Add a directional message to promote JIRA_ACCESS_TOKEN

dongjoon-hyun commented on code in PR #42704:
URL: https://github.com/apache/spark/pull/42704#discussion_r1307696554


##########
dev/merge_spark_pr.py:
##########
@@ -538,6 +538,9 @@ def initialize_jira():
             else:
                 raise e
     elif JIRA_USERNAME and JIRA_PASSWORD:
+        print("You can use JIRA_ACCESS_TOKEN instead of JIRA_USERNAME/JIRA_PASSWORD.")
+        print("Visit https://issues.apache.org/jira/secure/ViewProfile.jspa ")
+        print("and click 'Personal Access Tokens' menu to manage your own tokens.")

Review Comment:
   Nice catch! What is the minimum version of `jira` library for `token_auth`?
   I believe we had better specify the minimum version in our `requirements.txt` instead of a warning message.
   https://github.com/apache/spark/blob/c8a209251374c28868aea809f51c467fdd0d1443/dev/requirements.txt#L45
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org