You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/08/02 21:58:12 UTC
[GitHub] [beam] lostluck opened a new pull request, #27822: [#24789] Remainder of changes from #27550.
lostluck opened a new pull request, #27822:
URL: https://github.com/apache/beam/pull/27822
Remainder of changes from #27550 that have not yet been parceled into smaller CLs for enabling prism as default runner.
See #24789
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27822: [#24789] Remainder of changes from #27550.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27822:
URL: https://github.com/apache/beam/pull/27822#issuecomment-1668344039
I think the failure is a race condition between the logging output and the pipeline shutting down. Good to be aware of at least, for another prism adjustment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27822: [#24789] Remainder of changes from #27550.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27822:
URL: https://github.com/apache/beam/pull/27822#issuecomment-1666241139
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label go.
R: @bvolpato for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #27822: [#24789] Remainder of changes from #27550.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #27822:
URL: https://github.com/apache/beam/pull/27822#discussion_r1286157985
##########
sdks/go/pkg/beam/runners/vet/vet.go:
##########
@@ -54,7 +54,7 @@ func init() {
type disabledResolver bool
func (p disabledResolver) Sym2Addr(name string) (uintptr, error) {
- return 0, errors.Errorf("%v not found. Use runtime.RegisterFunction in unit tests", name)
+ return 0, errors.Errorf("%v not found. Register DoFns and functions with the the beam/register package.", name)
Review Comment:
Great catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #27822: [#24789] Remainder of changes from #27550.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #27822:
URL: https://github.com/apache/beam/pull/27822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27822: [#24789] Remainder of changes from #27550.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27822:
URL: https://github.com/apache/beam/pull/27822#issuecomment-1666228411
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27822](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cd16c24) into [master](https://app.codecov.io/gh/apache/beam/commit/ead1cefbf38b02a31b9c2baf0210ab05c2e3722c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ead1cef) will **decrease** coverage by `0.01%`.
> Report is 25 commits behind head on master.
> The diff coverage is `37.93%`.
```diff
@@ Coverage Diff @@
## master #27822 +/- ##
==========================================
- Coverage 70.87% 70.87% -0.01%
==========================================
Files 861 861
Lines 104995 105006 +11
==========================================
+ Hits 74419 74426 +7
- Misses 29017 29022 +5
+ Partials 1559 1558 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `53.70% <37.93%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/core/runtime/harness/harness.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9oYXJuZXNzLmdv) | `11.08% <0.00%> (ø)` | |
| [sdks/go/pkg/beam/core/runtime/harness/statemgr.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9zdGF0ZW1nci5nbw==) | `37.60% <0.00%> (-0.16%)` | :arrow_down: |
| [sdks/go/pkg/beam/core/runtime/symbols.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvc3ltYm9scy5nbw==) | `10.00% <0.00%> (ø)` | |
| [...am/runners/prism/internal/engine/elementmanager.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3ByaXNtL2ludGVybmFsL2VuZ2luZS9lbGVtZW50bWFuYWdlci5nbw==) | `82.05% <ø> (-0.05%)` | :arrow_down: |
| [...go/pkg/beam/runners/prism/internal/handlerunner.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3ByaXNtL2ludGVybmFsL2hhbmRsZXJ1bm5lci5nbw==) | `86.30% <ø> (ø)` | |
| [...o/pkg/beam/runners/prism/internal/worker/bundle.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3ByaXNtL2ludGVybmFsL3dvcmtlci9idW5kbGUuZ28=) | `51.64% <ø> (ø)` | |
| [...dks/go/pkg/beam/runners/universal/runnerlib/job.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3VuaXZlcnNhbC9ydW5uZXJsaWIvam9iLmdv) | `0.00% <0.00%> (ø)` | |
| [sdks/go/pkg/beam/core/runtime/harness/datamgr.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9kYXRhbWdyLmdv) | `56.71% <33.33%> (-0.17%)` | :arrow_down: |
| [sdks/go/pkg/beam/runners/prism/internal/stage.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3ByaXNtL2ludGVybmFsL3N0YWdlLmdv) | `85.67% <50.00%> (ø)` | |
| [sdks/go/pkg/beam/create.go](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9jcmVhdGUuZ28=) | `65.15% <100.00%> (+1.65%)` | :arrow_up: |
| ... and [2 more](https://app.codecov.io/gh/apache/beam/pull/27822?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27822/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on a diff in pull request #27822: [#24789] Remainder of changes from #27550.
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on code in PR #27822:
URL: https://github.com/apache/beam/pull/27822#discussion_r1285861617
##########
sdks/go/pkg/beam/runners/vet/vet.go:
##########
@@ -54,7 +54,7 @@ func init() {
type disabledResolver bool
func (p disabledResolver) Sym2Addr(name string) (uintptr, error) {
- return 0, errors.Errorf("%v not found. Use runtime.RegisterFunction in unit tests", name)
+ return 0, errors.Errorf("%v not found. Register DoFns and functions with the the beam/register package.", name)
Review Comment:
```suggestion
return 0, errors.Errorf("%v not found. Register DoFns and functions with the beam/register package.", name)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org