You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2014/03/12 21:32:30 UTC

svn commit: r1576885 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/thrift/HBaseThriftRPC.java

Author: liyin
Date: Wed Mar 12 20:32:30 2014
New Revision: 1576885

URL: http://svn.apache.org/r1576885
Log:
[HBASE-9930] Fix NPE in processListOfPuts.

Author: manukranthk

Summary: We were returning null in one of the locations when we failed to get a client object. We should be instead throwing an IOException in that case.

Test Plan: Run TestMultiParllelPut

Reviewers: gauravm, fan

Reviewed By: gauravm

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1205626

Task ID: 3864263

Modified:
    hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/thrift/HBaseThriftRPC.java

Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/thrift/HBaseThriftRPC.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/thrift/HBaseThriftRPC.java?rev=1576885&r1=1576884&r2=1576885&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/thrift/HBaseThriftRPC.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/ipc/thrift/HBaseThriftRPC.java Wed Mar 12 20:32:30 2014
@@ -117,7 +117,7 @@ public class HBaseThriftRPC {
       } catch (Exception e) {
         LOG.warn("Failed getting Client without Wrapper for address: " +
           addr.toString(), e);
-        return null;
+        throw new IOException(e);
       }
       return new Pair<> (client, clientsForConf.getThriftClientManager());
     } catch (Exception e) {