You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/13 09:43:33 UTC

[GitHub] [kafka] tombentley opened a new pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

tombentley opened a new pull request #9593:
URL: https://github.com/apache/kafka/pull/9593


   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rayokota commented on pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

Posted by GitBox <gi...@apache.org>.
rayokota commented on pull request #9593:
URL: https://github.com/apache/kafka/pull/9593#issuecomment-739080185


   This breaks existing client configurations that use `bootstrap.brokers=SASL_PLAINTEXT://localhost:49767` (due to the `_`)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison merged pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

Posted by GitBox <gi...@apache.org>.
mimaison merged pull request #9593:
URL: https://github.com/apache/kafka/pull/9593


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9593:
URL: https://github.com/apache/kafka/pull/9593#issuecomment-739139662


   Thanks @rayokota, obvious in hindsight. I've opened https://github.com/apache/kafka/pull/9701


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rayokota edited a comment on pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

Posted by GitBox <gi...@apache.org>.
rayokota edited a comment on pull request #9593:
URL: https://github.com/apache/kafka/pull/9593#issuecomment-739080185


   This breaks existing client configurations that use `bootstrap.servers=SASL_PLAINTEXT://localhost:49767` (due to the `_`)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9593:
URL: https://github.com/apache/kafka/pull/9593#issuecomment-726661732


   @mimaison would you be able to take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org