[GitHub] [phoenix-omid] stoty commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.

[GitBox <gi...@apache.org>]

stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r940355736


##########
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##########
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
      */
     private boolean skipCellVersion(Cell cell) {
         return skipColumn != null
-        && CellUtil.matchingRow(cell, skipColumn.getRowArray(), skipColumn.getRowOffset(),
+        && PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(), skipColumn.getRowOffset(),

Review Comment:
   Don't use PrivateCellUtil anywhere, it's InterfaceAudience.Private.
   Use the methods in the Public CellUtil.
   



##########
hbase-commit-table/src/main/java/org/apache/omid/committable/hbase/HBaseCommitTable.java:
##########
@@ -144,7 +145,10 @@ public boolean atomicAddCommittedTransaction(long startTimestamp, long commitTim
                 Put put = new Put(transactionRow, startTimestamp);
                 byte[] value = encodeCommitTimestamp(startTimestamp, commitTimestamp);
                 put.addColumn(commitTableFamily, COMMIT_TABLE_QUALIFIER, value);
-                return table.checkAndPut(transactionRow, commitTableFamily, INVALID_TX_QUALIFIER, null, put);
+                CheckAndMutate checkAndPut = CheckAndMutate.newBuilder(transactionRow)
+                        .ifEquals(commitTableFamily, INVALID_TX_QUALIFIER, null)

Review Comment:
   While this is correct, using the new ifNotExist() method would more descriptive.
   The same applies to the other ifEquals(null) calls.



##########
hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestCompactorScanner.java:
##########
@@ -67,7 +67,7 @@ public void testShouldRetainNonTransactionallyDeletedCellMethod(int optionIdx, b
 
         RegionCoprocessorEnvironment rce = mock(RegionCoprocessorEnvironment.class);
         HRegion hRegion = mock(HRegion.class);
-        HRegionInfo hRegionInfo = mock(HRegionInfo.class);
+        RegionInfo hRegionInfo = mock(RegionInfo.class);

Review Comment:
   Renaming the variable to match the type would make it easier to read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org