You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Bisk1 (via GitHub)" <gi...@apache.org> on 2023/08/29 15:59:07 UTC
[GitHub] [airflow] Bisk1 opened a new pull request, #33893: Cleanup: remove remnants of 'shutdown' task instance state
Bisk1 opened a new pull request, #33893:
URL: https://github.com/apache/airflow/pull/33893
Follow-up of #33746 - several mentions of 'shutdown' task were left behind, e.g. in docs
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33893:
URL: https://github.com/apache/airflow/pull/33893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #33893:
URL: https://github.com/apache/airflow/pull/33893#discussion_r1309052714
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -76,7 +76,6 @@ The possible states for a Task Instance are:
* ``queued``: The task has been assigned to an Executor and is awaiting a worker
* ``running``: The task is running on a worker (or on a local/synchronous executor)
* ``success``: The task finished running without errors
-* ``shutdown``: The task was externally requested to shut down when it was running
Review Comment:
Should a note be added below this list to mention there used to be a shutdown state but not anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33893:
URL: https://github.com/apache/airflow/pull/33893#issuecomment-1697867204
> We need also to update the diagram in the page
Diagram has been already updated in the previous PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bisk1 commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state
Posted by "Bisk1 (via GitHub)" <gi...@apache.org>.
Bisk1 commented on code in PR #33893:
URL: https://github.com/apache/airflow/pull/33893#discussion_r1309061275
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -76,7 +76,6 @@ The possible states for a Task Instance are:
* ``queued``: The task has been assigned to an Executor and is awaiting a worker
* ``running``: The task is running on a worker (or on a local/synchronous executor)
* ``success``: The task finished running without errors
-* ``shutdown``: The task was externally requested to shut down when it was running
Review Comment:
I felt like it's not useful information because users of new version won't see 'shutdown' state and if someone has older version they should look at relevant, older docs. There probably should be an update in release notes though. But I can modify it if you're sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33893:
URL: https://github.com/apache/airflow/pull/33893#discussion_r1309154222
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -76,7 +76,6 @@ The possible states for a Task Instance are:
* ``queued``: The task has been assigned to an Executor and is awaiting a worker
* ``running``: The task is running on a worker (or on a local/synchronous executor)
* ``success``: The task finished running without errors
-* ``shutdown``: The task was externally requested to shut down when it was running
Review Comment:
We discussed it in https://github.com/apache/airflow/pull/33746 and it turned out that SHUTDOWN not only has been deeply buried and nearly forgotten but also it has never been working for things like API. So I think I would prefer to pretend it never existed :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bisk1 commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state
Posted by "Bisk1 (via GitHub)" <gi...@apache.org>.
Bisk1 commented on code in PR #33893:
URL: https://github.com/apache/airflow/pull/33893#discussion_r1309061275
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -76,7 +76,6 @@ The possible states for a Task Instance are:
* ``queued``: The task has been assigned to an Executor and is awaiting a worker
* ``running``: The task is running on a worker (or on a local/synchronous executor)
* ``success``: The task finished running without errors
-* ``shutdown``: The task was externally requested to shut down when it was running
Review Comment:
I felt like it's not useful information for the typical audience of the docs because the docs are meant for specific Airflow version and if someone has older version they should look at relevant, older docs. There probably should be an in release notes though. But I can modify it if you're sure.
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -76,7 +76,6 @@ The possible states for a Task Instance are:
* ``queued``: The task has been assigned to an Executor and is awaiting a worker
* ``running``: The task is running on a worker (or on a local/synchronous executor)
* ``success``: The task finished running without errors
-* ``shutdown``: The task was externally requested to shut down when it was running
Review Comment:
I felt like it's not useful information for the typical audience of the docs because the docs are meant for specific Airflow version and if someone has older version they should look at relevant, older docs. Probably should show in release notes. But I can modify it if you're sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bisk1 commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state
Posted by "Bisk1 (via GitHub)" <gi...@apache.org>.
Bisk1 commented on code in PR #33893:
URL: https://github.com/apache/airflow/pull/33893#discussion_r1309061275
##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -76,7 +76,6 @@ The possible states for a Task Instance are:
* ``queued``: The task has been assigned to an Executor and is awaiting a worker
* ``running``: The task is running on a worker (or on a local/synchronous executor)
* ``success``: The task finished running without errors
-* ``shutdown``: The task was externally requested to shut down when it was running
Review Comment:
I felt like it's not useful information because users of new version won't see 'shutdown' state and if someone has older version they should look at relevant, older docs. There probably should be an in release notes though. But I can modify it if you're sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #33893:
URL: https://github.com/apache/airflow/pull/33893#issuecomment-1697865311
We need also to update the diagram in the page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org