You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ishan Chattopadhyaya (JIRA)" <ji...@apache.org> on 2017/03/13 16:42:42 UTC
[jira] [Commented] (SOLR-9454) Reduce object allocation during
indexing because of JavaBinCodec.writeExternString()
[ https://issues.apache.org/jira/browse/SOLR-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907795#comment-15907795 ]
Ishan Chattopadhyaya commented on SOLR-9454:
--------------------------------------------
Moving to 6.5, since 6.4 has already been released.
> Reduce object allocation during indexing because of JavaBinCodec.writeExternString()
> ------------------------------------------------------------------------------------
>
> Key: SOLR-9454
> URL: https://issues.apache.org/jira/browse/SOLR-9454
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud, update
> Reporter: Shalin Shekhar Mangar
> Labels: difficulty-medium, impact-medium
> Fix For: 6.5, master (7.0)
>
> Attachments: HashMapNode_Allocations.png, HashMapNodeArray_Allocations.png, javabin-optimization.patch, SOLR-9454.patch
>
>
> I setup Java Flight Recorder to profile indexing a 650MB JSON file using bin/post on 2 shard, 2 replica setup. It shows that the JavaBinCodec.writeExternString(String) method contributes a lot of garbage during indexing in SolrCloud. More specifically, it contributes ~1GB of HashMap$Node objects and ~450MB of HashMap$Node[] objects.
> Most of this allocation is because every request is serialized using a new instance of JavaBinUpdateRequestCodec which internally allocates a new HashMap for storing the extern strings.
> We should explore keeping a global extern string map to eliminate redundant allocations.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org