You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@opendal.apache.org by "unixzii (via GitHub)" <gi...@apache.org> on 2023/06/15 01:19:19 UTC

[GitHub] [incubator-opendal] unixzii commented on a diff in pull request #2461: feat(core): add capability check

unixzii commented on code in PR #2461:
URL: https://github.com/apache/incubator-opendal/pull/2461#discussion_r1230315585


##########
core/tests/behavior/capability.rs:
##########
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   I found many tests don’t cover the capability checks. For example, presign tests will check the capability in their preludes, and just skip the test body if it’s not supported. To ensure the check is working for users, we need to simulate the use cases where users blindly perform some unsupported operations without checking the capability first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org