You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Megha Sharma <ms...@apple.com> on 2017/07/17 22:08:10 UTC

Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60925/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Updated CHANGELOG for changed semantic of recovery.


Diffs
-----

  CHANGELOG 978747fc11c90a0d73d6815823474f974bc0c82e 
  docs/agent-recovery.md 1b3f2d2d2e630478a8d577eaa6474e3aedc3cb89 
  docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac 


Diff: https://reviews.apache.org/r/60925/diff/1/


Testing
-------


Thanks,

Megha Sharma


Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60925/#review180761
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60925]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 17, 2017, 3:10 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60925/
> -----------------------------------------------------------
> 
> (Updated July 17, 2017, 3:10 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: 6223
>     https://issues.apache.org/jira/browse/6223
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated CHANGELOG for changed semantic of recovery.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 978747fc11c90a0d73d6815823474f974bc0c82e 
>   docs/agent-recovery.md 1b3f2d2d2e630478a8d577eaa6474e3aedc3cb89 
>   docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac 
> 
> 
> Diff: https://reviews.apache.org/r/60925/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60925/#review180813
-----------------------------------------------------------


Ship it!




Committing with some minor edits.

- Jiang Yan Xu


On July 17, 2017, 5:35 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60925/
> -----------------------------------------------------------
> 
> (Updated July 17, 2017, 5:35 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6223
>     https://issues.apache.org/jira/browse/MESOS-6223
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated CHANGELOG for changed semantic of recovery.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 978747fc11c90a0d73d6815823474f974bc0c82e 
>   docs/agent-recovery.md 1b3f2d2d2e630478a8d577eaa6474e3aedc3cb89 
>   docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac 
> 
> 
> Diff: https://reviews.apache.org/r/60925/diff/2/
> 
> 
> Testing
> -------
> 
> Testing done, renders correctly.
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60925/
-----------------------------------------------------------

(Updated July 17, 2017, 5:35 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-6223
    https://issues.apache.org/jira/browse/MESOS-6223


Repository: mesos


Description
-------

Updated CHANGELOG for changed semantic of recovery.


Diffs
-----

  CHANGELOG 978747fc11c90a0d73d6815823474f974bc0c82e 
  docs/agent-recovery.md 1b3f2d2d2e630478a8d577eaa6474e3aedc3cb89 
  docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac 


Diff: https://reviews.apache.org/r/60925/diff/2/


Testing
-------

Testing done, renders correctly.


Thanks,

Megha Sharma


Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60925/
-----------------------------------------------------------

(Updated July 18, 2017, 12:02 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: 6223
    https://issues.apache.org/jira/browse/6223


Repository: mesos


Description
-------

Updated CHANGELOG for changed semantic of recovery.


Diffs
-----

  CHANGELOG 978747fc11c90a0d73d6815823474f974bc0c82e 
  docs/agent-recovery.md 1b3f2d2d2e630478a8d577eaa6474e3aedc3cb89 
  docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac 


Diff: https://reviews.apache.org/r/60925/diff/2/


Testing (updated)
-------

Testing done, renders correctly.


Thanks,

Megha Sharma


Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60925/
-----------------------------------------------------------

(Updated July 18, 2017, 12:02 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: 6223
    https://issues.apache.org/jira/browse/6223


Repository: mesos


Description
-------

Updated CHANGELOG for changed semantic of recovery.


Diffs (updated)
-----

  CHANGELOG 978747fc11c90a0d73d6815823474f974bc0c82e 
  docs/agent-recovery.md 1b3f2d2d2e630478a8d577eaa6474e3aedc3cb89 
  docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac 


Diff: https://reviews.apache.org/r/60925/diff/2/

Changes: https://reviews.apache.org/r/60925/diff/1-2/


Testing
-------


Thanks,

Megha Sharma


Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60925/
-----------------------------------------------------------

(Updated July 17, 2017, 10:10 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: 6223
    https://issues.apache.org/jira/browse/6223


Repository: mesos


Description
-------

Updated CHANGELOG for changed semantic of recovery.


Diffs
-----

  CHANGELOG 978747fc11c90a0d73d6815823474f974bc0c82e 
  docs/agent-recovery.md 1b3f2d2d2e630478a8d577eaa6474e3aedc3cb89 
  docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac 


Diff: https://reviews.apache.org/r/60925/diff/1/


Testing
-------


Thanks,

Megha Sharma